After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167915 - Desentivise volume up/down items properly when boundary is reached
Desentivise volume up/down items properly when boundary is reached
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
0.101
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 335647 (view as bug list)
Depends on: 353560
Blocks:
 
 
Reported: 2005-02-20 00:06 UTC by Michaël Arnauts
Modified: 2006-09-20 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix this bug (1.95 KB, patch)
2006-09-19 21:22 UTC, Jan Arne Petersen 		accepted-commit_now Details | Review

Description Michaël Arnauts 2005-02-20 00:06:08 UTC 
I guess this bug exists since the split of the glade files... I'm not sure...
Anyway, the volume up and volume down items in the popup are disabled.
Perhaps, when the volume is at max, the volume up entry could be disabled since
pressing it doesn't do anything? The same for the volume min ofcourse :)
The items in the mainmenu are working. If you implement the disabling of
min/plus when volume is at min/plus, don't forget the items in the mainmenu.
Comment 1 Bastien Nocera 2005-02-20 16:21:34 UTC 
2005-02-20  Bastien Nocera  <hadess@hadess.net>

        * NEWS: upd
        * src/totem.c: (totem_action_set_mrl_with_warning):
        enable the volume items in the popup menu properly (Closes: #167915)

That fixes the main bug.
Comment 2 Bastien Nocera 2006-03-27 11:03:55 UTC 
*** Bug 335647 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2006-09-04 21:03:23 UTC 
This should be made easier by bug 353560
Comment 4 Jan Arne Petersen 2006-09-19 21:22:42 UTC 
Created attachment 73060 [details] [review]
patch to fix this bug
Comment 5 Bastien Nocera 2006-09-19 23:00:32 UTC 
Looks good.
Comment 6 Jan Arne Petersen 2006-09-20 17:11:00 UTC 
2006-09-20  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* src/totem-private.h:
	* src/totem.c: (totem_action_set_mrl_with_warning),
	(update_volume_sliders): desensitive volume-up and volume-down actions
	when boundary (100 or 0) is reached. (Closes: #167915)