GNOME Bugzilla – Bug 167195
Inconsistent gnome-applets gweather schema descriptions
Last modified: 2010-01-24 01:07:00 UTC
<schema> <key>/schemas/apps/gweather/prefs/location0</key> <owner>gweather-applet-2</owner> <type>string</type> <locale name="C"> <default>DEFAULT_LOCATION</default> <short>weather location information.</short> <long>weather location information.</long> </locale> </schema> <schema> <key>/schemas/apps/gweather/prefs/location1</key> <owner>gweather-applet-2</owner> <type>string</type> <locale name="C"> <default>DEFAULT_CODE</default> <short>weather location information.</short> <long>weather location information.</long> </locale> </schema> <schema> <key>/schemas/apps/gweather/prefs/location2</key> <owner>gweather-applet-2</owner> <type>string</type> <locale name="C"> <default>DEFAULT_ZONE</default> <short>weather location information.</short> <long>weather location information.</long> </locale> </schema> <schema> <key>/schemas/apps/gweather/prefs/location3</key> <owner>gweather-applet-2</owner> <type>string</type> <locale name="C"> <default>DEFAULT_RADAR</default> <short>weather location information.</short> <long>weather location information.</long> </locale> </schema> <schema> <key>/schemas/apps/gweather/prefs/location4</key> <owner>gweather-applet-2</owner> <type>string</type> <locale name="C"> <default>DEFAULT_LOCATION</default> <short>weather location information.</short> <long>weather location information.</long> </locale> </schema> <schema> <key>/schemas/apps/gweather/prefs/coordinates</key> <owner>gweather-applet-2</owner> <type>string</type> <locale name="C"> <default>DEFAULT_COORDINATES</default> <short>location coordinates</short> <long>latitude and longitude of your location expressed in DD-MM-SS[NS] DD-MM-SS[EW]</long> </locale> </schema> The <long> and <short> descriptions of these keys aren't very helpful... In addition, the descriptions should start with an uppercase letter. Furthermore, <short> descriptions are supposed to be written without ending periods, while <long> descriptions should end in a period.
We should put more descriptive schema names into libgweather. Marking this as something that could be done by a GNOME Lover.
Created attachment 64444 [details] [review] Corrects long and short descriptions Patch applies to CVS HEAD 2006 04 27. I couldn't figure out what location0 was, so I just "fixed" it.
The patch from Comment #2 adds labels, which is great and sorely needed. What it doesn't add is anything regarding how to choose appropriate data. For example, <long>Nearby major zone, such as a capital city.</long> What would be great is a URL in the <long> strings that shows a list that people can choose from. I.e., <long>Nearby major zone, such as a capital city, as appears in URL.</long> Also, is <long>Weather location information.</long> really the optimal descriptor for DEFAULT_LOCATION? I'd also recommend the following quick grammar/spelling nits: <long>A uniquie zone for the city.</long> Should be "unique" <long>A three digit long code for retrieving radar maps.</long> Should be "three-digit-long"
Created attachment 64624 [details] [review] Updated patch to include source information. I don't know what DEFAULT_LOCATION is used for? Just from grepping gweather and libgweather folders, I honestly can't say I grasp all of what the code is doing, but I can't tell where either DEFAULT_LOCATION or location0 is actually used.
Bump. Any response?
2006-07-23 Davyd Madeley <davyd@madeley.id.au> * gweather.schemas.in: update schema descriptions, patch from Adam Petaccia. Closes #167195.