GNOME Bugzilla – Bug 166795
HTTP Method does not send Accept-Charset and Accept-Language headers
Last modified: 2011-05-07 23:29:09 UTC
Please describe the problem: The HTTP method does not send these headers in the HTTP request, making it impossible to request locale-specific names for remote shares and the like. The attached patch adds these headers, so that we request UTF-8, and content in the user's language based on their environment, using g_get_language_names () in glib 2.6. Steps to reproduce: Open the "Network" place in Gnome. Actual results: The network share names are not translated. Expected results: Network shares that can be translated on the server, are translated to the user's locale, when possible. Does this happen every time? Yes. Other information:
Created attachment 37242 [details] [review] Patch to add request headers to both versions of HTTP method
Thanks for your bug report and your efforts!
Can I please put this in?
Maybe you could submit it to the development mailing list [1] for review? Thanks in advance! [1] http://mail.gnome.org/mailman/listinfo/gnome-vfs-list
It doesn't apply to HEAD any more anyway, due to the HTTP changes there. I guess I'll have to rewrite the patch for HEAD if Christian K. didn't take these changes into account when messing with the HTTP stuff for 2.14, like he said he would.
gnome-vfs has been deprecated and superseded by gio/gvfs since GNOME 2.22, hence mass-closing many of the gnome-vfs requests/bug reports. This means that gnome-vfs is NOT actively maintained anymore, however patches are still welcome. If your reported issue is still valid for gio/gvfs, please feel free to file a bug report against glib/gio or gvfs. @Bugzilla mail recipients: query for gnome-vfs-mass-close to get rid of these notification emails all together. General further information: http://en.wikipedia.org/wiki/GVFS Reasons behind this decision are listed at http://www.mail-archive.com/gnome-vfs-list@gnome.org/msg00899.html
Any http-using code in gio/gvfs should do this too.
Once there is support in libsoup for that, it will be added to gvfs.
Committed as 927d91c to git master. > GET / HTTP/1.1 > Soup-Debug-Timestamp: 1304810305 > Soup-Debug: SoupSessionAsync 1 (0xde88c0), SoupMessage 1 (0xe3d830), SoupSocket 1 (0xe4b010) > Host: www.google.de > User-Agent: gvfs/1.9.0 > Accept-Language: en-us, en;q=0.9, en;q=0.8