After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165732 - clock applet should ignore weather calendar info (see comment 25)
clock applet should ignore weather calendar info (see comment 25)
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
git master
Other All
: Normal enhancement
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on: 351930
Blocks:
 
 
Reported: 2005-01-30 18:55 UTC by Priit Laes (IRC: plaes)
Modified: 2015-03-24 13:01 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch tries to add more information to the time field. (4.36 KB, patch)
2005-07-15 07:46 UTC, Priit Laes (IRC: plaes)
none Details | Review
Separates appointments into weather, birthdays and appointments. (19.77 KB, patch)
2005-07-19 18:29 UTC, Priit Laes (IRC: plaes)
needs-work Details | Review
Screenshot... (13.12 KB, image/png)
2005-07-19 18:30 UTC, Priit Laes (IRC: plaes)
  Details
Patch which adds icon support, IMHO it needs some more work (too late here... :P) (25.68 KB, patch)
2005-07-19 21:25 UTC, Priit Laes (IRC: plaes)
none Details | Review
Required icons... (2.76 KB, application/x-compressed-tar)
2005-07-19 21:26 UTC, Priit Laes (IRC: plaes)
  Details
Added icon support (25.26 KB, patch)
2005-07-20 10:19 UTC, Priit Laes (IRC: plaes)
none Details | Review
Final patch, updated the ChangeLog (25.91 KB, patch)
2005-07-26 11:35 UTC, Priit Laes (IRC: plaes)
none Details | Review
gnome-clock-applet-filter-weather-bdays.patch (24.51 KB, patch)
2007-03-28 09:07 UTC, Priit Laes (IRC: plaes)
none Details | Review
clock-applet-separate-events.patch (27.49 KB, patch)
2007-03-31 14:38 UTC, Priit Laes (IRC: plaes)
none Details | Review
Updated to trunk (22.12 KB, patch)
2007-05-13 23:57 UTC, Vincent Untz
committed Details | Review
clock-eds-pixmaps.patch (3.83 KB, patch)
2007-05-22 12:50 UTC, Priit Laes (IRC: plaes)
none Details | Review

Description Priit Laes (IRC: plaes) 2005-01-30 18:55:55 UTC
When I have clock-applet linked with evolution and I am using weather calendar,
it displays ugly "Whole day event" item in the list.

IMHO, it should ignore it or somehow display it a bit nicer way.
Comment 1 Vincent Untz 2005-01-30 21:06:06 UTC
One solution is to stop using the weather calendar plugin in evolution.
But we'll try to find a better solution
Comment 2 William Jon McCann 2005-05-09 02:58:10 UTC
Is a duplicate of bug 161188?
Comment 3 Priit Laes (IRC: plaes) 2005-07-13 17:12:28 UTC
Yup, the same problem applies to the weather and birthday calendars
Comment 4 Priit Laes (IRC: plaes) 2005-07-15 07:46:49 UTC
Created attachment 49210 [details] [review]
Patch tries to add more information to the time field.

This is preliminary patch, I think better approach would be adding icon instead
of the "Birthday" or Weather text.
Comment 5 Priit Laes (IRC: plaes) 2005-07-19 18:29:05 UTC
Created attachment 49413 [details] [review]
Separates appointments into weather, birthdays and appointments.
Comment 6 Priit Laes (IRC: plaes) 2005-07-19 18:30:08 UTC
Created attachment 49414 [details]
Screenshot...
Comment 7 Vincent Untz 2005-07-19 18:54:04 UTC
Great!
Looks like a good start. If you can add some icons at the left of the labels,
it'd definitely be great! I'm also not sure we need the color for the weather.

Small comments about the formatting (just one example, but valid for the whole
patch ;-)):

+static gchar *
+get_source_uri (ECal *esource)
+{
+    ESource *source;
+    gchar *string;
+    gchar **list;
Should be:
+    ESource  *source;
+    gchar    *string;
+    gchar   **list;

+
+    g_return_val_if_fail (E_IS_CAL (esource), NULL);
+
+    source = e_cal_get_source (esource);
+    string = g_strdup(e_source_get_uri (source));
Should be:
+    string = g_strdup (e_source_get_uri (source));

+    if (string) {
+        list = g_strsplit(string, ":", 2);
+        g_free(string);
Should be:
+        list = g_strsplit (string, ":", 2);
+        g_free (string);

etc.

Thanks again!
Comment 8 Priit Laes (IRC: plaes) 2005-07-19 21:25:37 UTC
Created attachment 49428 [details] [review]
Patch which adds icon support, IMHO it needs some more work (too late here... :P)

Icons will follow...
Comment 9 Priit Laes (IRC: plaes) 2005-07-19 21:26:56 UTC
Created attachment 49430 [details]
Required icons...
Comment 10 Vincent Untz 2005-07-19 23:40:21 UTC
> IMHO it needs some more work

I hope you won't mind if I wait a bit to review it, then :-) (it's late here too!)
Comment 11 Priit Laes (IRC: plaes) 2005-07-20 10:19:22 UTC
Created attachment 49448 [details] [review]
Added icon support

Cleaned formatting, needs review to cut down number of new functions...
Comment 12 Priit Laes (IRC: plaes) 2005-07-26 11:35:48 UTC
Created attachment 49768 [details] [review]
Final patch, updated the ChangeLog

Final patch from me, any idea whether this lands into 2.12?
Comment 13 Priit Laes (IRC: plaes) 2005-12-15 09:20:14 UTC
Any idea whether this lands in 2.14? :)
Comment 14 Vincent Untz 2005-12-15 16:13:52 UTC
Oh, thanks for pinging. I'll try to take a look at it soon. Feel free to ping me
again if there's no answer in two weeks.
Comment 15 Luis Menina 2006-01-26 14:47:34 UTC
ping :)
Comment 16 Diego Escalante Urrelo (not reading bugmail) 2006-05-10 08:11:20 UTC
PING! :P
Comment 17 Mart Raudsepp 2006-06-23 09:25:51 UTC
PING :)
Comment 18 Priit Laes (IRC: plaes) 2006-06-23 09:31:46 UTC
Smells like GUADEC hackfest :)
Comment 19 Wouter Bolsterlee (uws) 2006-10-26 12:51:37 UTC
Can we get this in for 2.18?
Comment 20 Diego Escalante Urrelo (not reading bugmail) 2007-01-24 08:27:21 UTC
(In reply to comment #14)
> Oh, thanks for pinging. I'll try to take a look at it soon. Feel free to ping me
> again if there's no answer in two weeks.

PING!
Comment 21 Priit Laes (IRC: plaes) 2007-03-28 09:07:33 UTC
Created attachment 85432 [details] [review]
gnome-clock-applet-filter-weather-bdays.patch

Diff against the trunk.. Didn't test troughoughly, but at least birthdays were visible.
Comment 22 Vincent Untz 2007-03-28 09:16:32 UTC
Could you update the patch so that each list is contained in a GtkExpander (for tasks list and appointments list too). Else, this will become really huge.
Comment 23 Priit Laes (IRC: plaes) 2007-03-31 14:38:32 UTC
Created attachment 85611 [details] [review]
clock-applet-separate-events.patch

GtkExpanded version.
Comment 24 Vincent Untz 2007-05-13 23:57:45 UTC
Created attachment 88138 [details] [review]
Updated to trunk

Updated patch to trunk (I commented out the part about icons in Makefile.am). I modified it a bit for things that made sense.

It's nearly ready to go in. Still to do:
 + figure out why the color doesn't work anymore for appointments (might be evolution being broken here)
 + have only one selection in the 4 GtkTreeViews (when you select an appointment, it should unselect in the other 3 TreeeViews)
 + save the state of the expanders in gconf
Comment 25 Vincent Untz 2007-05-20 16:32:50 UTC
I've committed an improved version of the latest patch (state of the expanders are state during the applet lifecycle). I don't have colors for appointments without the patch either, so I'm assuming this issue doesn't come from the patch, but from eds.

Remaining things to do:
 + save the state of the expanders in gconf
 + have only one selection for the 4 treeviews
 + use icons: some are provided in comment 9, but I'd prefer to use system-wide icons if possible.
Comment 26 Vincent Untz 2007-05-20 22:12:32 UTC
FWIW, I've done the "save the state of the expanders in gconf" item. Still two things to do.
Comment 27 Vincent Untz 2007-05-21 20:21:38 UTC
I've fixed the "have only one selection for the 4 treeviews" item.

Can someone investigate the icons issue? I'd really like to avoid installing them as part of the panel.
Comment 28 Priit Laes (IRC: plaes) 2007-05-22 05:07:56 UTC
On Gentoo evolution-data-server (from where I took the icons) installs pixmaps into /usr/share/pixmaps/evolution-data-server. 

What about your system, Vincent?
Comment 29 Wouter Bolsterlee (uws) 2007-05-22 08:02:42 UTC
e-d-s install pixmaps in to $prefix/share/pixmaps/evolution-data-server. This is leftover from the past... it should be using $prefix/share/icons/hicolor instead methinks...
Comment 30 Wouter Bolsterlee (uws) 2007-05-22 08:04:28 UTC
Hmm no. It seems this is the way: http://live.gnome.org/ThemableAppSpecificIcons
Comment 31 Vincent Untz 2007-05-22 09:18:24 UTC
Wouter, well, it's not the right way since it's in $prefix/share/pixmaps instead of $pkgdatadir/icons.

Priit: I believe some of the icons are here, yes. Want to make a patch for this? :-)
Comment 32 Priit Laes (IRC: plaes) 2007-05-22 12:34:48 UTC
Hum.. maybe we should first file a bug against evolution so it would install its icons to right place?
Comment 33 Priit Laes (IRC: plaes) 2007-05-22 12:50:17 UTC
Created attachment 88601 [details] [review]
clock-eds-pixmaps.patch

Something like this popped into my mind.. 

WARNING: This is only compile tested.. ;)
Comment 34 Priit Laes (IRC: plaes) 2007-05-22 12:54:02 UTC
Few afterthoughts:
  * TYPO: libwnck dep was downgraded in order get things to configure ;)
  * the warning message when icon file not found should probably mention evolution-data-server and its icons?
  * Forgot to remove old outcommented DCLOCK_ICONDIR from Makefile.am

And I'm on my sick leave.. :P
Comment 35 Vincent Untz 2007-05-25 14:12:43 UTC
I've committed something based on this.

Thanks!