GNOME Bugzilla – Bug 165732
clock applet should ignore weather calendar info (see comment 25)
Last modified: 2015-03-24 13:01:06 UTC
When I have clock-applet linked with evolution and I am using weather calendar, it displays ugly "Whole day event" item in the list. IMHO, it should ignore it or somehow display it a bit nicer way.
One solution is to stop using the weather calendar plugin in evolution. But we'll try to find a better solution
Is a duplicate of bug 161188?
Yup, the same problem applies to the weather and birthday calendars
Created attachment 49210 [details] [review] Patch tries to add more information to the time field. This is preliminary patch, I think better approach would be adding icon instead of the "Birthday" or Weather text.
Created attachment 49413 [details] [review] Separates appointments into weather, birthdays and appointments.
Created attachment 49414 [details] Screenshot...
Great! Looks like a good start. If you can add some icons at the left of the labels, it'd definitely be great! I'm also not sure we need the color for the weather. Small comments about the formatting (just one example, but valid for the whole patch ;-)): +static gchar * +get_source_uri (ECal *esource) +{ + ESource *source; + gchar *string; + gchar **list; Should be: + ESource *source; + gchar *string; + gchar **list; + + g_return_val_if_fail (E_IS_CAL (esource), NULL); + + source = e_cal_get_source (esource); + string = g_strdup(e_source_get_uri (source)); Should be: + string = g_strdup (e_source_get_uri (source)); + if (string) { + list = g_strsplit(string, ":", 2); + g_free(string); Should be: + list = g_strsplit (string, ":", 2); + g_free (string); etc. Thanks again!
Created attachment 49428 [details] [review] Patch which adds icon support, IMHO it needs some more work (too late here... :P) Icons will follow...
Created attachment 49430 [details] Required icons...
> IMHO it needs some more work I hope you won't mind if I wait a bit to review it, then :-) (it's late here too!)
Created attachment 49448 [details] [review] Added icon support Cleaned formatting, needs review to cut down number of new functions...
Created attachment 49768 [details] [review] Final patch, updated the ChangeLog Final patch from me, any idea whether this lands into 2.12?
Any idea whether this lands in 2.14? :)
Oh, thanks for pinging. I'll try to take a look at it soon. Feel free to ping me again if there's no answer in two weeks.
ping :)
PING! :P
PING :)
Smells like GUADEC hackfest :)
Can we get this in for 2.18?
(In reply to comment #14) > Oh, thanks for pinging. I'll try to take a look at it soon. Feel free to ping me > again if there's no answer in two weeks. PING!
Created attachment 85432 [details] [review] gnome-clock-applet-filter-weather-bdays.patch Diff against the trunk.. Didn't test troughoughly, but at least birthdays were visible.
Could you update the patch so that each list is contained in a GtkExpander (for tasks list and appointments list too). Else, this will become really huge.
Created attachment 85611 [details] [review] clock-applet-separate-events.patch GtkExpanded version.
Created attachment 88138 [details] [review] Updated to trunk Updated patch to trunk (I commented out the part about icons in Makefile.am). I modified it a bit for things that made sense. It's nearly ready to go in. Still to do: + figure out why the color doesn't work anymore for appointments (might be evolution being broken here) + have only one selection in the 4 GtkTreeViews (when you select an appointment, it should unselect in the other 3 TreeeViews) + save the state of the expanders in gconf
I've committed an improved version of the latest patch (state of the expanders are state during the applet lifecycle). I don't have colors for appointments without the patch either, so I'm assuming this issue doesn't come from the patch, but from eds. Remaining things to do: + save the state of the expanders in gconf + have only one selection for the 4 treeviews + use icons: some are provided in comment 9, but I'd prefer to use system-wide icons if possible.
FWIW, I've done the "save the state of the expanders in gconf" item. Still two things to do.
I've fixed the "have only one selection for the 4 treeviews" item. Can someone investigate the icons issue? I'd really like to avoid installing them as part of the panel.
On Gentoo evolution-data-server (from where I took the icons) installs pixmaps into /usr/share/pixmaps/evolution-data-server. What about your system, Vincent?
e-d-s install pixmaps in to $prefix/share/pixmaps/evolution-data-server. This is leftover from the past... it should be using $prefix/share/icons/hicolor instead methinks...
Hmm no. It seems this is the way: http://live.gnome.org/ThemableAppSpecificIcons
Wouter, well, it's not the right way since it's in $prefix/share/pixmaps instead of $pkgdatadir/icons. Priit: I believe some of the icons are here, yes. Want to make a patch for this? :-)
Hum.. maybe we should first file a bug against evolution so it would install its icons to right place?
Created attachment 88601 [details] [review] clock-eds-pixmaps.patch Something like this popped into my mind.. WARNING: This is only compile tested.. ;)
Few afterthoughts: * TYPO: libwnck dep was downgraded in order get things to configure ;) * the warning message when icon file not found should probably mention evolution-data-server and its icons? * Forgot to remove old outcommented DCLOCK_ICONDIR from Makefile.am And I'm on my sick leave.. :P
I've committed something based on this. Thanks!