After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165689 - Use gdk_x11_display_get_last_user_time() from gtk+ 2.8
Use gdk_x11_display_get_last_user_time() from gtk+ 2.8
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
git master
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Reported: 2005-01-30 12:11 UTC by Mark McLoughlin
Modified: 2006-04-11 19:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Should fix the crash (817 bytes, patch)
2006-04-11 15:31 UTC, Vincent Untz
committed Details | Review

Description Mark McLoughlin 2005-01-30 12:11:23 UTC
In ditem_execute() we should use gdk_x11_display_get_last_user_time() rather
than gtk_get_current_event_time(). See bug #150910 for more details.

(Can't do this until when we're using gtk+ 2.8)
Comment 1 Vincent Untz 2006-03-25 17:37:04 UTC
Fixed in HEAD.
Comment 2 Richard Hult 2006-04-11 14:51:35 UTC
This change causes a crash in some situations where screen is NULL, for example when calling gnome_desktop_item_launch() since it just passes NULL for screen to gnome_desktop_item_launch_on_screen_with_env().
Comment 3 Vincent Untz 2006-04-11 15:31:02 UTC
Created attachment 63241 [details] [review]
Should fix the crash

I can not test the patch right now. If somebody can... :-)
I'll release a release if it works.
Comment 4 Richard Hult 2006-04-11 17:29:13 UTC
I built a debian package with your patch, seems to work nicely and I don't get the crash now. Thanks!
Comment 5 Vincent Untz 2006-04-11 19:42:08 UTC