GNOME Bugzilla – Bug 165684
Save image as .xcf when no extension has been typed
Last modified: 2008-01-15 12:46:49 UTC
If newbies then save a file they do not have to remember what the extension of gimp files are + files are then automatically saved in the best format
Confirming and setting to 2.4 as this seems to be standard behavior and is a real usability problem.
See also bug #159616
Created attachment 37049 [details] [review] A Patch against CVS head that hopefully fixes this problem. This is a patch against CVS head that fixes the problem (at least from what I tried).
Comment on attachment 37049 [details] [review] A Patch against CVS head that hopefully fixes this problem. The patch doesn't conform to the coding style. I also don't like that it changes the parameters passed to file_save_as(). The file functions are already quite confusing. Introducing another set of parameter names won't improve that. Perhaps you can modify the patch a little?
OK, I fixed the missing whitespace before the ( for function calls in my copy. I couldn't find any other coding style problems. I don't change the parameters - they are the same arglist, and the parameters themselves are not modified. What I did change was the parameter names, so I can declare different variables with the names of the original parameters, but the ones that are actually going to be used. Do you want me to convert input_raw_filename and input_uri back into raw_filename and uri, and find different names for the processed variables?
Yes, that's what I meant to ask you for.
Created attachment 37117 [details] [review] A Patch to correct the problem, corrected according to Sven's input Here's a more corrected patch. The style problems were fixed, and now the parameter names were restored to the original ones.
2005-02-10 Sven Neumann <sven@gimp.org> * app/file/file-save.c (file_save_as): applied a (slightly modified) patch from Shlomi Fish that automatically adds the .xcf extension if none is given (bug #165684).
*** Bug 167527 has been marked as a duplicate of this bug. ***
Suggest a commit to the 2.2 branch as well.
It's an enhancement, not a bug-fix. And the patch that I committed wasn't sufficient at all. Mitch spent a whole day to fix it up and the code is still full of debugging output. We are certainly not going to backport this change.
*** Bug 324105 has been marked as a duplicate of this bug. ***
*** Bug 432763 has been marked as a duplicate of this bug. ***