GNOME Bugzilla – Bug 165598
Keyboard shortcuts don't work in fullscreen
Last modified: 2007-03-22 11:29:33 UTC
The delete button work well when in normal collection view, displaying many images at once. Once the application is switched to fullscreen mode, the delete button stops responding which is annoying and hard to understand for a non-technical user. Other information:
Confirmed with 2.10.0.
In fact, no keyboard shortcuts seem to work in fullscreen, except three shortcuts that close the fullscreen view: Esc, Ctrl-W, F11. Changing the title of this bug to reflect this.
*** Bug 322010 has been marked as a duplicate of this bug. ***
All keyboard shortcuts work fine in fullscreen but the Del one in EOG 2.13.3.
*** Bug 331567 has been marked as a duplicate of this bug. ***
Ctrl+0 shortcut doesn't work in fullscreen mode anymore, while Ctrl+- and Ctrl++ work just fine.
this is in eog-2.14.0
*** Bug 338825 has been marked as a duplicate of this bug. ***
IMHO the most nasty shortcut that is missing is the one for rotation. If I show a set of pictures to friends I usually do this in fullscreen mode, but then I can't rotate the pictures I took in portrait mode :-( I've looked into the code a bit. There are basically three files where shortcuts are defined /shell/eog-window.c This contains all the shortcuts you'll see in the menu and these are executed when we see the eog window. handles: zooming, rotation, image deletion, fullscreen, prev/next image /libeog/eog-scroll-view.c has shortcuts for scrolling the image up down left right when there are scrollbars and also handles zooming /libeog/eog-full-screen.c defines shortcuts for leaving fullscreen, prev/next image and the shortcuts defined in eog-window.c do not when we are in this mode. So in order to have some shortcuts working in fullscreen we should add code to /libeog/eog-full-screen.c, but it's not clear to me (yet) how I for example can do rotation overthere. But this brings me to another question. Currently shortcuts for the same operation are defined at multiple places in the code and this ofcourse leads to inconsistencies (e.g. the Ctrl+0 shortcut not working in fullscreen, while it works while there is a window) Isn't there a way we can get all these shortcuts defined in one place?
Hey Jaap, actually, in eog-ng branch I plan to remove this separate fullscreen implementation (which has lots of duplicated code) and make full screen a mode of eog-window. This would solve this problem.
Cool!! Are you already hacking in the eog-ng branch?? Is eog-ng planned for 2.16??
eog-ng branch, which has a full rewrite of eog's core, has been merged into trunk as part of 2.19/2.20 development cycle. Therefore this bug is fixed now. Thanks for the report!
*** Bug 420857 has been marked as a duplicate of this bug. ***