GNOME Bugzilla – Bug 165550
Disable keyboard shortcut for menubar when locked down
Last modified: 2012-10-07 16:02:53 UTC
Disable F10 keyboard shortcut for menubar when hide_menubar lockdown key is enabled.
I've fixed this in cvs on HEAD and gnome-2-8 not to show the menubar when locked down. Should we just make the menubar itself inaccessible, or should we also not allow any shortcut keys to activate the menu actions themselves?
Christian, yeah, i think it should function as if the menubar didn't exist at all -- i.e. no keyboard shortcuts from the menu should be accessable. Obviously any shortcuts corresponding to context menu item should still be accessable. Btw, do you think that a lockdown key for "disable-context-menu" could be useful too?
Fixed in cvs HEAD. The UI manager has only one accel group for menu and context actions, but this doesn't matter since context menus don't have shortcuts. I split the context menu lockdown to bug 165984.
My point was that if the menubar is disabled, the user should still be able to use the shortcuts for functions which are available on the context menu - e.g. Ctrl+D should still add a bookmark, Ctrl+A should still Select All, etc. The reason the shortcuts not being shown on right-click menus is for clarity.
I see. That seems impossible to implement, though, since the menubar and the context menus share the accel group.
Created attachment 36885 [details] [review] patch this is the patch that was backed out since it caused accels not to work also in the popup window without menubar case
We discussed this in irc, and I decided to punt this to 1.8. spark does that disable stuff like ctrl+z for undo? chpe I reverted the patch chpe yeah chpe also it disabled all accels in popups without menubar but without lockdown mode spark oh right i just got the email. spark chpe: is it possible to make another accel group for context menus, but not show them in the menu? chpe should I revert the schemas patch too ? * lu|meeting is now known as luis spark chpe: what was the schemas patch? chpe spark: that would mean using another UI manager (which means duplication of actions etc...)... not sth I'd like to do chpe changing the string to just "Hide the menubar" spark chpe: is there any way to disable individual accels without disabling the whole group? spark chpe: maybe we could just unset the accel of the ones we don't want to allow? chpe don't know spark chpe: yep, the schemas patch needs to be reverted too (we don't want to imply that it prevents access to the menubar) spark btw, i made a 2.8 plan area on the wiki... spark just copyed off 2.6 at the moment. * caillon is now known as caillon_mtg spark chpe: how do you lock down prefs? spark chpe: how is the menubar disabled in full screen mode? chpe spark: in the dialogues you mean? if the gconf key isn't writable we set them insensitive resp. ineditable (for entries) spark chpe: how do i set that? chpe spark: just not shown, you can activate it with the GNOME menu accel (F10 by default) spark chpe: that doesn't work for me... spark (works in normal mode but not f s) chpe spark: either add a read-only gconf source, or (I think) newer gconf-editor adding a mandatory setting chpe spark: you still on suse with 1.2.x? spark yep. chpe doesn't work there iirc spark hmm, ok. chpe yeah, not implemented in 1.2.x spark chpe: we don't want the menubar in f s mode tho do we? chpe spark: why not? spark chpe: if you want the menubar you can use normal mode. chpe spark: yeah, but why not allow to activate it with F10 when you need it ? chpe (it's still hidden when not active) * reinouts_ (~reinout@swpc445.cs.vu.nl) has joined #epiphany spark chpe: because it makes lockdown much harder. spark chpe: i suppose if we had a working "disable-menubar" it would be ok... spark chpe: i just find it odd that a keyboard shortcut can activate something that isn't there.... spark chpe: also pretty undiscoverable... spark (unless you happen to know that F10 focuses the menubar) chpe spark: yeah... chpe I just see no way to make it work, without duplicating all actions etc... not nice spark chpe: how come it works right in 1.2 then? chpe spark: it does? what happens when you press Ctrl-S in fs mode, for example? spark nothing. chpe hmm interesting * chpe checks the code spark oh wait, that's cause its ctrl+shift+s spark you were right. spark again spark chpe: but surely unseting the accels would work ok? chpe unsetting ? spark chpe: like just set the accel to be nothing. spark chpe: like you can do graphical if you enable the gconf key to allow editting accels. spark chpe: then reset the accel to what it was before when the menubar becomes enabled again. chpe spark: that would disable only the known accels, not accels the user might have added chpe (and I'm not sure how it can be done) spark chpe: you'd get the accels you want to disable by querying the current accel of the relevent menu items. chpe it would be easier to just make all undesired actions insensitive instead spark ok then :p spark all nice elegent solutions i'm sure you'll agree ;) chpe well... it has its complications too, since some actions are in context menus too, and we still want the undo/copy/paste actions etc... chpe I'll punt to 1.8 I think... I'm not really satisfied with the whole lockdown implementation architecture... I tried to refactor it, but it's a major thing spark ok
Perhaps my installation is a bit borked because I played with development releases, but the hide_menubar currently does nothing at all here (2.20).
There is no more menu bar (and F10 doesn't do anything anymore)...