GNOME Bugzilla – Bug 165533
Show Progress bar in the main window itself
Last modified: 2005-07-14 10:36:29 UTC
Reasons for this Changes: 1. Instead of poping up a seperate progress window, the progress could be shown in the main windows itself for each track. 2. This improves the user friendliness as the user will know the status of the Extraction process, ie how many tracks have been ripped and how many is still remaining. 3. The user also can see the percentage ripped so far.
Created attachment 36665 [details] Snap shot of the changes Snap shot showing the progress bar for each track.
Created attachment 36724 [details] While extracting, the "Extract" label has been changed to "Cancel" A new label added to show the Remaining time and speed
Created attachment 36727 [details] Change the "Cancel" label back to "Extract" when extract is clicked
Created attachment 36828 [details] [review] Patch for the changes against CVS HEAD
*** Bug 142707 has been marked as a duplicate of this bug. ***
My vision: When Extract is pressed, the Extract button becomes Cancel, the status bar reports the overall percentage complete and estimated time remaining, and each track is highlighted as it is extracted. Maybe bold the current extracting track, add a small icon, or fade (disable) the completed and not to be ripped tracks.
You could try looking at the code in the GIMP (added during the 2.2 development cycle) which did just this. Dave.
Ross: when the track_listview is made insensitive, and when an icon is displayed to indicate the current ripping track.. the icon is grayed out. Should i let that like that or i need to make that specific column sensitive...
Am working on it. Done: 1. Current ripping task is indicated by a gtk-cdrom icon, finished track by gtk-apply icon, and cancelled track by gtk-cancel icon. 2. The progress dialog is removed and brought to the main UI and shows the progress of the current track. 3. Overall ripping status is shown in the status bar. Remaining Taks: 1. To bold the current ripping track.
Created attachment 39485 [details] Snapshot Snapshot - When sj starts ripping
Created attachment 39486 [details] Snapshop, when ripping finishes one track
Created attachment 39487 [details] snapshot when ripping is cancelled
Try putting the progress bar in the status bar -- GnomeApp does this so it should be quit easy. I also noticed that the icons are faded, I presume this is due to the GtkTreeView being disabled. I wonder if this can be avoided.
Should the progress bar correspond to the current track rip progress, or to the overall rip progress?
My current idea is a single progress bar, in the status bar, which shows the overall progress.
Thanks Ross for the comment :)
Created attachment 48461 [details] Snapshot while extracting Progress bar along with the status bar The progress bar indicates the total progress time and it has been placed along with the status bar. Using GnomeApp, the same kind of progress bar and status bar can be got, but GnomeApp used many deprecated functions. So, a seperate progress bar and status bar is used. TODO: 1. To enable the Pixbuf column while extracting 2. To Highlight the current extracting column
Created attachment 48462 [details] Extraction cancelled
Oh cool. If you want to be my *best friend ever*, start to merge this with the work in the "sj-player-branch" CVS branch of Sound Juicer. The contents of that branch will be HEAD shortly.
Sure, i love to,.. ;)
Created attachment 48508 [details] Snapshot for the sj-player-branch head source
Created attachment 48518 [details] [review] Patch against the sj-player-branch
Created attachment 48579 [details] [review] Patch against the CVS HEAD 1. The progress dialog has been removed and brought to the main UI 2. The sensitivity of the track_listview is not disabled while extration and the Extract column alone is made INERT while extraction is in progress. This is done so that, the Stock item is seen clearly while extracting 3. on_tracklist_row_activate handler is blocked while extraction is in progress.
Created attachment 48580 [details] Snapshot while extracting
Created attachment 48612 [details] Snapshot while extracting
Created attachment 48613 [details] Snapshot when Extraction is cancelled Ross: I have used GTK-APPLY to indicate that a track has been ripped successfully, and GTK-CANCEL, if any error occurs or Extraction is cancelled. GTK_STOCK_MEDIA_RECORD would indicate the ripping track. Is this behaviour OK ?
Not sure about an icon for ripped songs... leave it in for now as long as all state is restored so there are no icons once the rip is complete. Can you attach your latest patch?
Created attachment 48619 [details] [review] Latest patch against CVS HEAD
... label = gtk_label_get_text (extract_label); if (!(strcmp (label, "Stop"))) { ... That won't work in any locale other than the one you write that compare in, so won't work. Why not use a static gboolean in sj-extracting.c? And to re-label a button at runtime see cb_state() in sj-play.c.
Created attachment 48642 [details] [review] Updated patch Ross, The re-label cannot be done as per cb_state in sj-play.c Since, there the Play and Pause label are used which can be changed by just changing the Stock Item. But, for GTK_STOCK_CDROM, we need to set "Extract" label. GTK_STOCK_STOP can be used to set the label "Stop", but using this makes it difficult to change the label to "Extract" So, as in the patch, the re-label has been done at run time
Ross: Should i have to create a new Gtk Stock Item for Extract button. Then it can be done as you said.
SJ in CVS now has a stock item factory.
SJ in CVS now has SJ_STOCK_EXTRACT for the extract button.
Created attachment 49149 [details] [review] Updated Patch against CVS HEAD Updated patch using the SJ stock items
Rock on! I like how the final patch is about half the size of the first one. :) Committed to HEAD.