Created attachment 36232 [details] [review]
fix

Works for me...

Will this patch cause any problems with Mozilla < 1.8?  I know that in standard
autoconf controlled modules, unknown --enable-foo=XXX and --with-foo=XXX
arguments are ignored.

Assuming mozilla doesn't do anything too weird, it should be okay too.  If so,
then you may as well commit the mozillamodule.py part now.

Note that we probably want the older module sets to still be able to reference
an old branch of Mozilla (if the API changes, for instance), so if the
mozillamodule.py changes don't work with old versions that would be a problem.

I slightly modified the patch to not cause problems to the current/old mozilla
build and checked in.
If you get problem reports about this please reassign to me...

Given that mozilla 1.8 is not happening, should the moduleset portion of this be
committed now?

Given the release target for Firefox 1.1 (which is using the mozilla 1.8
platform), it probably does make sense to switch over.  I'd guess that distros
shipping Gnome 2.12 will also be shipping Firefox 1.1 ...

It is likely that most 2.12-shipping distros will ship ff1.1, but only because
most distros lag- any timely distro (ubuntu, maybe fc5?) would likely not have a
ff1.1 that would be ready in time, judging from their past history on hitting
schedules and their current target date (which is slightly *after* 2.12.)