After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 163947 - crasher: rsvg_handle_get_pixbuf doesn't check pointer returned by rsvg_new_drawing_ctx
crasher: rsvg_handle_get_pixbuf doesn't check pointer returned by rsvg_new_dr...
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
unspecified
Other Linux
: High critical
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-13 15:59 UTC by John Spray
Modified: 2005-01-13 16:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Patch to check for division by zero in new_drawing_ctx and handle null return value in rsvg_handle_get_pixbuf (1.02 KB, patch)
2005-01-13 16:02 UTC, John Spray 		none Details | Review

Description John Spray 2005-01-13 15:59:59 UTC 
rsvg_handle_get_pixbuf uses rsvg_new_drawing_ctx to get a new DrawingCtx. 
However, under certain conditions rsvg_new_drawing_ctx returns NULL. 
rsvg_handle_get_pixbuf doesn't check this before passing the pointer to
rsvg_drawing_ctx_free.

This may be related to epiphany bug 163886
Comment 1 John Spray 2005-01-13 16:02:42 UTC 
Created attachment 35957 [details] [review]
Patch to check for division by zero in new_drawing_ctx and handle null return value in rsvg_handle_get_pixbuf

This fixes bug 163886 for me, and I think it's quite reasonable regardless of
that particular case.
Comment 2 Dominic Lachowicz 2005-01-13 16:51:28 UTC 
the patch looks reasonable. i'll commit it. thanks.