After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 163854 - show minimized applications as dimmed in the window selector
show minimized applications as dimmed in the window selector
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: window selector
git master
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-12 20:28 UTC by Vincent Noel
Modified: 2005-01-12 22:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to dimm the application icon (1.21 KB, patch)
2005-01-12 21:35 UTC, Vincent Noel
accepted-commit_now Details | Review

Description Vincent Noel 2005-01-12 20:28:01 UTC
Right now minimized applications are shown in the window selector as surrounded
by "[" and "]". It's better than nothing, but still for me it's not obvious
enough what it means.

The window list applet dims the application icon, in addition to the "[]". That
would be a good first step, but what I'd like to see is dimming both the
application icon and name in the list. The distinction between minimized and
opened windows would be obvious at a glance.
Comment 1 Vincent Untz 2005-01-12 20:36:52 UTC
Patches welcome :-)
Comment 2 Vincent Noel 2005-01-12 21:35:10 UTC
Created attachment 35915 [details] [review]
patch to dimm the application icon

You read my mind ;-)
This patch dimms the application icon when the window is minimized.

I stole the function from libwnck in tasklist.c. I thought maybe this should be
handled in libwnck in the window-menu.c file, but it looks like libwnck's
window-menu.c is never used in the panel's window-menu.c. This is confusing ;-)
Comment 3 Vincent Noel 2005-01-12 21:40:24 UTC
For dimming the text itself, I'm not quite sure how to do that.
And I guess it would have to take accessibility into account...
Comment 4 Vincent Untz 2005-01-12 21:43:53 UTC
Vincent: see bug #156917 :-)
In fact, if you could fix bug #156917, it'd be the best solution for a lot of
things...
Comment 5 Vincent Untz 2005-01-12 21:44:52 UTC
Comment on attachment 35915 [details] [review]
patch to dimm the application icon

Please commit the patch, but reindent it the way it's in window-menu.c (tabs,
'if () {' on the same line, etc.). Also, remove the useless line before the
call to window_menu_dimm_icon().

Thanks
Comment 6 Vincent Noel 2005-01-12 22:18:14 UTC
Ok, I committed a updated patch. Indentation always gets me ;-)
Actually the wnck_dimm_icon function was statically defined in tasklist.c, so
even if we used libwnck's window-menu, we'd have to duplicate it (or extract it
in some general utility file...)