GNOME Bugzilla – Bug 163245
Location bar "Go to" button needed
Last modified: 2009-11-17 11:29:41 UTC
Distribution: Fedora Core release 3 (Heidelberg) Package: nautilus Severity: enhancement Version: GNOME2.8.0 unspecified Gnome-Distributor: Red Hat, Inc Synopsis: Location bar "Go to" button needed Bugzilla-Product: nautilus Bugzilla-Component: Navigation Bugzilla-Version: unspecified Description: Please describe your feature request: As it should be possible to navigate in Nautilus using only the mouse, a "Go to" button is needed. When it is pressed Nautilus will show the contents of the location in the location bar. Presently one has to hit Return after having pasted a location in the location bar with the mouse. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2005-01-07 11:31 ------- Unknown platform unknown. Setting to default platform "Other". Unknown milestone "unknown" in product "nautilus". Setting to default milestone for this product, '---' The original reporter of this bug does not have an account here. Reassigning to the person who moved it here, unknown@bugzilla.gnome.org. Previous reporter was fusionfive@spray.se. Setting to default status "UNCONFIRMED". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
probably not a current use case but that's right
I think this would be really great as it's inconsistent not having a "go" button. I tried working on this but I found that a normal button looked really ugly. Obviously toolbar buttons don't look so ugly so I wanted to use one of those, this is because only on mouse over do they appear as a button. Toolbar buttons (in nautilus anyway) are implemented using GtkGroup. Is there anyway to do a normal button with only showing the edges on mouse over like GtkGroup?
Created attachment 71944 [details] [review] add a go button on the text based location bar This patch adds a go button on location bar that's text based. This improves consistency with browsers such as epiphany and firefox. It does not have an icon presently but neither does epiphany so I didn't know any to use...
Would it be possible to do this like Firefox 3.X; with an icon at the end (inside) of the text entry? And only show it when the user has changed the location (again, just as firefox does)? Would that be prettier/cleaner/enough? Using http://library.gnome.org/devel/gtk/unstable/GtkEntry.html#gtk-entry-set-icon-from-icon-name and http://library.gnome.org/devel/gtk/unstable/GtkEntry.html#GtkEntry-icon-press it seems possible. I could create a patch for it if you're interested.
Actually in nautilus 2.28 the location bar now has a clean entry icon at the end. So it seems we have four options; 1) Replace the clean icon with a "go" icon (probably the play icon?) 2) Add a go button 3) Change between clean and go icon in the entry. When user has changed the text display go otherwise clean (might be confusing) 4) Do nothing (aka close this bug) Comments?
While I'm at it, I might as well try to review the patch. Why can't we just use gtk_widget_set_tooltip_text () [1] instead of all the other code? (Maybe that function weren't available back then - but it is now) With that the patch will be much smaller. [1] http://library.gnome.org/devel/gtk/2.15/GtkWidget.html#gtk-widget-set-tooltip-text
Created attachment 144849 [details] [review] Add go button to location bar
Created attachment 144850 [details] Screenshot of location bar with go button Sorry for spamming.
Adding more stuff to the toolbar for such a limited usecase seems wrong to me. Removing/replacing the clear entry icon would be against the usecase for the go button too (i.e. it would make keyboard less middle click paste harder since you need to clear before pasting). However, toggling from "clear" to "go" when the entry is "changed" seems like a good solution to me, and is similar to how e.g. firefox does it (although their non-changed icon is "bookmark" rather than "clear").
Comment on attachment 71944 [details] [review] add a go button on the text based location bar Setting patches status.
Created attachment 145245 [details] [review] * Changed the "event-after" signal to "changed" to update the "Location" / "Go to" label * Change the secondary icon in the location to a "Go" (play) icon when the label is "Go to" otherwise a clear icon
Comment on attachment 145245 [details] [review] * Changed the "event-after" signal to "changed" to update the "Location" / "Go to" label * Change the secondary icon in the location to a "Go" (play) icon when the label is "Go to" otherwise a clear icon src/nautilus-location-entry.h 56 NAUTILUS_LOCATION_ENTRY_GOTO, 57 NAUTILUS_LOCATION_ENTRY_CLEAR 58 }; We should give this enum a typedef (e.g. NautilusLocationEntryAction). src/nautilus-location-entry.c 62 gboolean setting_special_text; 63 gchar *special_text; 64 gint secondary_action; Use the type that we define for this enum. (same applies for line #339). 299 default: 300 g_assert_not_reached (); 301 } Bad indenting (heh, gotta notice this every time, sorry.) 351 gtk_entry_set_icon_from_stock (GTK_ENTRY (entry), 352 GTK_ENTRY_ICON_SECONDARY, 353 GTK_STOCK_MEDIA_PLAY); Media-play is the definitely the wrong icon to use here. It will look fine in some themes, but semantically it's very wrong. "Apply" or "OK" is closer to what we mean. Maybe we should ask for a GTK_STOCK_GO?
Comment on attachment 144849 [details] [review] Add go button to location bar This patch was obsoleted by the other one.
Created attachment 145305 [details] [review] Changed the "event-after" signal to "changed" to update the "Location" / "Go to" label Change the secondary icon in the location to a "Go" (play) icon when the label is "Go to" otherwise a clear icon
Created attachment 145306 [details] Location entry with GTK_STOCK_GO_FORWARD icon After discussion with alex it's was decided that the icon should be GTK_STOCK_GO_FORWARD
Attachment 145305 [details] pushed as f146e05 - Changed the "event-after" signal to "changed" to update the "Location" / "Go to" label Change the secondary icon in the location to a "Go" (play) icon when the label is "Go to" otherwise a clear icon