After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162911 - GTK_FILE_SYSTEM_ERROR is public API in a private header
GTK_FILE_SYSTEM_ERROR is public API in a private header
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.6.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 143632
 
 
Reported: 2005-01-04 12:48 UTC by Murray Cumming
Modified: 2011-02-04 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Murray Cumming 2005-01-04 12:48:43 UTC 
On Wed, 2004-11-17 at 12:36 -0500, Matthias Clasen wrote, on gtk-devel-list:
> On Wed, 2004-11-17 at 12:25, Murray Cumming wrote:
> > GTK_FILE_SYSTEM_ERROR is defined in the semi-private gtkfilesystem.h
> > header, but it looks like the public FileChooser API can return GErrors of
> > type GTK_FILE_SYSTEM_ERROR sometimes. So, is this public or really
> > private? I mean, would an application developer ever check whether a
> > GError is a GTK_FILE_SYSTEM_ERROR?
> > 
> > I ask because we wrap GError types as separate C++ exception classes in
> > gtkmm.
> > 
> 
> Hmm, looks like we need to 
> 
> a) move the file system error enum to some public header
> b) document what errors can be returned where
Comment 1 Matthias Clasen 2005-01-05 04:58:12 UTC 
Should probably do this for 2.6.1 if we want to fix it at all in 2.6.x
Comment 2 Matthias Clasen 2005-01-05 17:18:07 UTC 
2005-01-05  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilechooserdefault.c: Don't construct errors from 
	the GTK_FILE_SYSTEM_ERROR domain. Partial fix for #162911.
	(get_file_info, check_is_folder): Translate errors from
	the filesystem into the GTK_FILE_CHOOSER_ERROR domain. Rest
	of the fix for #162911, noticed by Murray Cumming.