GNOME Bugzilla – Bug 162814
Actions on click and double-click in the video area
Last modified: 2007-02-18 20:40:00 UTC
From bug 145367: " hmmm, i just noticed that there isn't any action associated when you double/single click on the movie. i suggest to have a double click toggle the fullscreen-mode and a single click should pauze the movie. "
What about menus in the video area?
We can disable this behaviour when playing a DVD or VCD, or we could hide the button presses from the front-end if we're successfully generating an event for the backend.
i think the last way is the best one, pass the keypresses to the frontend if it isn't handled by the backend. btw, i just switched from the xine backend to the gstreamer one. It's awsome! :)
*** Bug 164989 has been marked as a duplicate of this bug. ***
*** Bug 171692 has been marked as a duplicate of this bug. ***
hello, Is this (very good) idea dead ?
I second this request. Double-click/Fullscreen is very much desired!
Created attachment 55847 [details] [review] Enables full screen with double click.
The patch in comment #8 should also work with DVD menus since events are propagated to the backend.
Don't know which application I picked it up from, but I have been using Totem for a year now, and still try to double click to go fullscreen now and then... please add this functionality. =)
*** Bug 331894 has been marked as a duplicate of this bug. ***
Created attachment 61037 [details] [review] New patch, which includes both toggle_fullscreen and action_play_pause The DVD menu issue is still open, but until today i have not seen a dvd menu with neither gstreamer0.8 nor 0.10 :)
Thanks for the patch. Could you please test this (and possibly fix it) with the xine-lib backend and a DVD menu?
Yeah, just tested and doesn't work with menus.
Created attachment 61084 [details] [review] totem-click-actions.patch I still don't like the way it behaves on dbl-clicks on a menu.
After using it for a month now, the most annoying thing is that i accidently pause the video when i only want to give the focus to totem, especially if the controls are hidden. But thanks to gst 0.10 play / pause are almost so its not as bad as in gst 0.8 and maybe i can get used to it :)
We should probably ignore the first click on the video then. I'll see what I can do about that.
*** Bug 344107 has been marked as a duplicate of this bug. ***
I don't think pausing the movie with a single click would be a good feature. In fact, it'll end up being more annoying than helpful. I think it would be best to pause with a double-click, and toggle fullscreen mode using the middle-click (that button is now more widely-used thanks to Firefox and Opera, which use it to open links in new tabs). 5 other features that would be very useful in future releases of Totem : 1. "snapping" window at one corner of the screen automatically on load (option). The video Window would then be resized accordingly (if the window is positioned at the bottom right corner of the screen, Totem resizes by only changing the position of the upper left corner of the window) 2. option to save Totem's last state and position (controls display, x/y coordinates) 3. display a borderless video window (no menu, no controls). It is possible to do so using Xine. 4. option to resume playback. Let's suppose I don't have time to play a Friends episode all the way through. I close Totem and I go to work. When I come back from work, I load the same video file (in the same path) and Totem automatically resumes the playback from the last scene I watched (by saving the timestamp of each video played). 5. automatically enqueue "linked" video files. Example: I have two video files: "The Matrix (1 of 2).avi" and "The Matrix (2 of 2).avi". When loading "The Matrix (1 of 2).avi", Totem could detect the second file using regular expression matching. Just my two cents. Keep up the good work, I love Totem !
(In reply to comment #19) > I don't think pausing the movie with a single click would be a good feature. In > fact, it'll end up being more annoying than helpful. I think it would be best > to pause with a double-click, and toggle fullscreen mode using the middle-click > (that button is now more widely-used thanks to Firefox and Opera, which use it > to open links in new tabs). That would certainly make it easier, as I realised that trying to focus Totem, I would always end up pausing it... > 5 other features that would be very useful in future releases of Totem : Each suggestion should go in its own bug, Bugzilla isn't a forum, or a mailing-list... > 1. "snapping" window at one corner of the screen automatically on load > (option). The video Window would then be resized accordingly (if the window is > positioned at the bottom right corner of the screen, Totem resizes by only > changing the position of the upper left corner of the window) That's the window manager's job, and even then... > 2. option to save Totem's last state and position (controls display, x/y > coordinates) It already does that, to a certain extent. > 3. display a borderless video window (no menu, no controls). It is possible to > do so using Xine. Tried pressing 'H', or the "Hide controls" menu item? > 4. option to resume playback. Let's suppose I don't have time to play a Friends > episode all the way through. I close Totem and I go to work. When I come back > from work, I load the same video file (in the same path) and Totem > automatically resumes the playback from the last scene I watched (by saving the > timestamp of each video played). We can already do that, simply pause Totem, and exit GNOME. That's the session saving. > 5. automatically enqueue "linked" video files. Example: I have two video files: > "The Matrix (1 of 2).avi" and "The Matrix (2 of 2).avi". When loading "The > Matrix (1 of 2).avi", Totem could detect the second file using regular > expression matching. You're better off using a tool to put your files as a single one, or save a playlist.
*** Bug 359900 has been marked as a duplicate of this bug. ***
Info under duplicated bug: Click and drag could move the totem window One clic, play and pause Double clic, full screen and exit full screen Right clic, menu
(In reply to comment #20) > (In reply to comment #19) > > I don't think pausing the movie with a single click would be a good feature. In > > fact, it'll end up being more annoying than helpful. I think it would be best > > to pause with a double-click, and toggle fullscreen mode using the middle-click > > (that button is now more widely-used thanks to Firefox and Opera, which use it > > to open links in new tabs). > > That would certainly make it easier, as I realised that trying to focus Totem, > I would always end up pausing it... I think double-clicking for fullscreen is better option than middle-click. Most media players use it, like VLC, Xine, WMP, BSplayer... and i think the user is more used to double-click for fullscreen than any other way.
>I don't think pausing the movie with a single click would be a good feature. In >fact, it'll end up being more annoying than helpful. I think it would be best >to pause with a double-click, and toggle fullscreen mode using the middle-click >(that button is now more widely-used thanks to Firefox and Opera, which use it >to open links in new tabs). Please, don't do this. Like Adolfo says, _ALL_ other players use double clicking for full screen. A completely different setup for totem would only cause confusion. Have you ever consulted some users about your theoretical UI changes? Imho, switching to full screen is one of the most important functions of a good video player. Whenever I want to watch a movie I: 1. Open it. 2. Want to go to full screen. As a small experiment, I asked several friends (who have now knowledge about linux) to switch Totem to full screen. They always tried double-clicking first. Please add this feature to Totem, it can't be much work. Almost a year ago I proposed a small patch already! That the option to switch to full screen is not even in the context menu is simply embarrassing. The context menu still needs some polishing anyway, as it doesn't display the shortcut key for 'pause' either. (while the 'Movie'-menu does display it). Also, pressing the spacebar while in full screen does switch to windowed mode, but pressing the spacebar while in windowed mode does NOT switch to full screen. I still do not see the logic in that. Don't get me wrong guys, I think Totem is the best movie player for linux and I _really_ appreciate your work! But seriously, these things have been bugging me for over a year! If you want me to I could try to write a patch to fix these things, but seeing that my previous patch wasn't accepted I would like you to confirm that first. // Writser
Created attachment 74782 [details] [review] Adds actions in fullscreen, also only shows controls in top/bottom area The patch adds toggle fullscreen on double-click and play/pause toggle on single-click. This patch also changes when the controls are shown in fullscreen mode, to much like how MPlayer Classic works (controls are only shown when mouse cursor is in the bottom/top area of screen and are hidden otherwise). Testing is needed, 'cause it don't seem as if totem->windows_h is the value to use to determine current screen height (doesn't seem to compare well with event->root_y)
Comment on attachment 74782 [details] [review] Adds actions in fullscreen, also only shows controls in top/bottom area Kill this patch...
Created attachment 74808 [details] [review] Fullscreen and play/pause-toggle using mouse This patch adds toggle fullscreen on double-click and toggle play/pause on single-click. It's different from the 2006-03-11 path in that this one hides the fullscreen controls on play
The toggle play / pause on single click is debatable. As someone above pointed out, what happens if you try to drag the window around while alt pressed? Toggling fullscreen with double clicking seems a non-issue to me, it should be included in totem ASAP. I'm curious: what do others think about this? Am I the only one who is so annoyed by this bug?
Writser, ranting in bugzilla won't help get this bug fixed. Comment #15 tells you what the problems are (ie. when using menus, the double-click doesn't work right, and the backends, at least the xine-lib one, need updating). Furthermore, single-click to play/pause drove me up the walls. I think I'll go for middle-click play/pause, and double-click fullscreen/unfullscreen. Double-clicking still needs to be fixed. Rejecting attachment 74808 [details] [review] as it's pretty much the same as the one I posted, without the xine-lib changes.
2006-12-06 Bastien Nocera <hadess@hadess.net> * README: upd * src/backend/bacon-video-widget-xine.c: (xine_try_error), (bacon_video_widget_button_press), (bacon_video_widget_get_metadata_string), (bacon_video_widget_get_current_frame): * src/totem.c: (on_video_button_press_event), (video_widget_create): Remove old < 2.9.1 glib compat code in the xine-lib backend, Make double-click toggle fullscreen, and a middle click play/pause (Closes: #162814)
*** Bug 386573 has been marked as a duplicate of this bug. ***
That feature doesn't work with the gstreamer backend, that has been pointed on https://launchpad.net/ubuntu/+source/totem/+bug/80203 Do you want a new bug about that or reopening that one would be about right?
Open a new bug please.
*** Bug 409056 has been marked as a duplicate of this bug. ***