After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162555 - [win32] Please don't blink
[win32] Please don't blink
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other Windows
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on: 162790
Blocks:
 
 
Reported: 2004-12-30 16:35 UTC by j.gnome
Modified: 2005-01-12 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for gdk/win32 (12.39 KB, patch)
2005-01-02 11:49 UTC, Ivan Wong
none Details | Review
Prebuilt test binary (libgdk-win32-2.0-0.dll.bz2) (224.84 KB, application/x-bzip)
2005-01-02 11:52 UTC, Ivan Wong
  Details
revised patch for gdk/win32 (15.69 KB, patch)
2005-01-02 17:51 UTC, Ivan Wong
none Details | Review

Description j.gnome 2004-12-30 16:35:02 UTC
It would be nice if the UI didn't blink when copying and pasting or selecting a
cell while editing.

An animation in those situations is very useful, but blinking can be very (very)
irritating and distracting. Maybe an animated border like in Excel? (an ASCII
animation demo follows:)

- - - - -
 - - - - -
Comment 1 Morten Welinder 2004-12-31 00:33:32 UTC
We have the walking "ants" on the unix side.  The win32 side ought to have that
too.  What, precisely, are you seeing?
Comment 2 j.gnome 2004-12-31 09:49:37 UTC
I see blinking cell borders.

1) Blink: if I type = in A1 and then press the down arrow key (or click cell A2
with the mouse), the borders of A2 alternate between these two states:
"-- -- -- --"
"           " (no border)

2) No blink: if I type =A2 in A1, A2 gets thick blue borders that don't move:
"-- -- --"

This only works if you're using the fixed libgdk-win32 dll from bug 160343:
3) Blink: if I press ctrl-c in A2 to copy it, the borders blink again.

I tested with two separate computers. Windows XP, Gnumeric 1.4.1-rc4.
Comment 3 Morten Welinder 2004-12-31 16:21:10 UTC
Ok, thanks.  I am guessing that Windows is combining some updates we don't want
to.
Comment 4 Ivan Wong 2005-01-02 11:49:41 UTC
Created attachment 35356 [details] [review]
patch for gdk/win32

GDK_LINE_DOUBLE_DASH is not complete on Win32. Both GDK_LINE_ON_OFF_DASH and
GDK_LINE_DOUBLE_DASH are simulated by the Win32 pen style PS_DASH which means
that odd segments are not drawn. So by switching foreground/background color of
dash lines didn't work.



Furthermore, I can see on my xfree86 that even and odd segments are equal
width. However that's not the case with Windows (PS_DASH). The patch attached
try to simulate LineDoubleDash (instead of using PS_DASH) and dash_offset of
XSetDashes also.
Comment 5 Ivan Wong 2005-01-02 11:52:28 UTC
Created attachment 35357 [details]
Prebuilt test binary (libgdk-win32-2.0-0.dll.bz2)

Or get it from here:

http://www.ivanwong.info/gnumeric/libgdk-win32-2.0-0.dll
Comment 6 j.gnome 2005-01-02 13:12:09 UTC
Thanks, now it works. No more blinking.
1) walking ants
2) thick blue solid border "-----", doesn't move
3) walking ants
Comment 7 Ivan Wong 2005-01-02 17:51:07 UTC
Created attachment 35360 [details] [review]
revised patch for gdk/win32
Comment 8 Ivan Wong 2005-01-03 09:46:38 UTC
Opened a gtk+ bug (bug 162790)
Comment 9 Morten Welinder 2005-01-12 21:31:51 UTC
Fixed in gtk+.