After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 161862 - If a path is already present in the bookmarks list clicking on add bookmark adds it again
If a path is already present in the bookmarks list clicking on add bookmark a...
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Bookmarks
0.x.x [obsolete]
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-12-21 07:44 UTC by Subodh Soni
Modified: 2005-02-17 02:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Proposed patch (656 bytes, patch)
2004-12-21 09:03 UTC, egeetha 		none Details | Review
Proposed patch (656 bytes, patch)
2004-12-21 09:04 UTC, egeetha 		none Details | Review

Description Subodh Soni 2004-12-21 07:44:45 UTC 
1. Right click on any folder and select "Browse Folder"
2. Click on Bookmarks->Add Bookmark.
3. Repeat above steps multiple number of times.
4. The same folder path gets added as many times as you click on add bookmark.

Ideally if a path is already present in the bookmarks list then it should not
get added again.
Comment 1 egeetha 2004-12-21 09:03:18 UTC 
Created attachment 35076 [details] [review]
Proposed patch

Proposed patch - adds a path uri to the bookmark list only the first time.
Comment 2 egeetha 2004-12-21 09:04:44 UTC 
Created attachment 35077 [details] [review]
Proposed patch

Proposed patch - adds a path uri to the bookmark list only the first time. This
patch fixes bug#161859 - inconsistent behaviour of add bookmarks bug also.
Attaching the same patch to bug#161859.
Comment 3 Vijaykumar Patwari 2004-12-21 09:17:55 UTC 
Looks good. And its better to notify the user if bookmark already exists.
Comment 4 Vijaykumar Patwari 2004-12-21 09:21:21 UTC 
*** Bug 161859 has been marked as a duplicate of this bug. ***
Comment 5 Luis Villa 2005-01-03 05:10:53 UTC 
Comment on attachment 35076 [details] [review]
Proposed patch

Marking this patch obsolete in favor of the second one.
Comment 6 Martin Wehner 2005-02-17 02:59:31 UTC 
I moved the check into add_bookmark_for_current_location as that method's doc
blurb actually states that it does nothing if the bookmark already exists.
It's on HEAD, thanks.