After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 160005 - Channels are not taken into account in plug-in previews
Channels are not taken into account in plug-in previews
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: libgimp
git master
Other All
: Normal minor
: ---
Assigned To: GIMP Bugs
GIMP Bugs
: 588993 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-11-30 20:24 UTC by Ville Pätsi
Modified: 2018-05-24 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ville Pätsi 2004-11-30 20:24:37 UTC
Plug-ins' preview display shows all color channels even if some or all are
disabled or hidden.
Comment 1 Sven Neumann 2004-11-30 20:47:22 UTC
The plug-ins don't know anything about the visibility state of the channels in
the core and I don't think we want to change this. It would make the preview
widget unnecessarily complex. I am not saying that it can't be done but I think
it's not worth the effort. I'd vote to close as WONTFIX unless you can come up
with a good argument why this feature is absolutely needed.
Comment 2 Ville Pätsi 2004-11-30 20:52:34 UTC
I came across this when I tried to use selective gaussian blur on only the red
channel. The preview was basically useless in this case. I was trying to remove
noise by blurring the red and the green channels separately. I basically had to
do this by trial and error.
Comment 3 Sven Neumann 2004-11-30 21:10:46 UTC
That sounds like a reasonable use case. This would have to be implemented in the
preview widget then. Changing Component to libgimp.
Comment 4 Joao S. O. Bueno 2004-12-01 00:18:20 UTC
I do not think of this as an enhancement. If there are cases in which the 
preview is not previewing, then it is buggy. 
Comment 5 Sven Neumann 2004-12-01 11:26:16 UTC
Joao, please open your eyes. The severity of this bug report had been changed to
minor before you added your comment.
Comment 6 Joao S. O. Bueno 2004-12-01 15:52:23 UTC
Ok. I just did not want to overturn your decision. 
 
Anyway, I've taken a look at the preview widget file. Indeed, it doesn't know 
from which image the image it's drawing came from - so the API will need to be 
changed.  
 
Having everything that uses the preview to check wich channels are 
active/visible seems me to be simply stupid - ultimately, the preview should 
get to "know" from which image it came from, so it can checkk by itself which 
channels are visible. Moreover, if there are inactive but visible channels, 
the easier thing I can think of is for the preview to fetch the bitmap from 
the image itself. 
 
And it goes getting more complicated - this is for channels. What about 
selections, or other things that could chabnge the affected data on an image? 
 
So here is my question: would it be viable that the source of the image 
displayed on a preveiw widget would be a GimpImage itself? - Maybe it would be 
easier to copy all attributes, selection from the original image, and copy 
only the subject layer. 
Comment 7 Michael Natterer 2004-12-01 16:08:29 UTC
No API change needed, there is gimp_drawable_get_image()
Comment 8 Sven Neumann 2004-12-01 16:17:37 UTC
Joao, please stop adding such confusing comments here. The problem has been
confirmed  and I already outlined that the fix can be done entirely in the
GimpPreview widget and that the existing API is sufficient. Your comments in #6
don't make any sense.
Comment 9 Michael Natterer 2012-10-07 15:56:35 UTC
*** Bug 588993 has been marked as a duplicate of this bug. ***
Comment 10 GNOME Infrastructure Team 2018-05-24 11:17:41 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/104.