After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159930 - Patch to add city Vancouver, WA to Locations.xml
Patch to add city Vancouver, WA to Locations.xml
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
2.8.x
Other All
: Normal enhancement
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: locations-love
 
 
Reported: 2004-11-30 02:55 UTC by Aaron Gyes
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8


Attachments
Adds Vancouver, WA to locations.xml, unique station code and zone (2.52 KB, patch)
2004-11-30 02:56 UTC, Aaron Gyes
needs-work Details | Review
Adds Vancouver, WA zone and radar (373 bytes, patch)
2004-12-01 04:19 UTC, Aaron Gyes
none Details | Review
Adds Vancouver, WA zone and radar (373 bytes, patch)
2004-12-01 04:19 UTC, Aaron Gyes
none Details | Review

Description Aaron Gyes 2004-11-30 02:55:23 UTC
We are the third largest city in Washington state, if you consider Seattle and
Tacoma one supercity (they are). We've got our own station code, WVUO, that none
of the other cities in Locations.xml represent. Can this patch please be
applied?  I was able to put in the translations because (surprise!) we aren't
the only city that goes by the name of Vancouver.

Patch attatched.
Comment 1 Aaron Gyes 2004-11-30 02:56:11 UTC
Created attachment 34314 [details] [review]
Adds Vancouver, WA to locations.xml, unique station code and zone
Comment 2 Danielle Madeley 2004-11-30 06:33:19 UTC
Comment on attachment 34314 [details] [review]
Adds Vancouver, WA to locations.xml, unique station code and zone

You don't need to worry about translations. Patch the Locations.xml.in file
instead. See
http://mail.gnome.org/archives/gnome-love/2004-November/msg00030.html for more
information.
Comment 3 Aaron Gyes 2004-11-30 07:25:43 UTC
I just checked out Locations.xml.in, Vancouver, WA was already been added during
a previous commit. I only have gnome-applets 2.8.1.1, so I didn't have it here.

Thanks.
Comment 4 Aaron Gyes 2004-12-01 04:19:24 UTC
Created attachment 34346 [details] [review]
Adds Vancouver, WA zone and radar
Comment 5 Aaron Gyes 2004-12-01 04:19:32 UTC
Created attachment 34347 [details] [review]
Adds Vancouver, WA zone and radar
Comment 6 Aaron Gyes 2004-12-01 04:21:16 UTC
Sorry, double post. Anyways, I looked closer, and the Locations.xml.in in cvs
didn't actually include the <zone> or <radar>, just the <code>.

This patch should suffice.
Comment 7 Danielle Madeley 2004-12-20 08:46:38 UTC
Committed. Thankyou.