After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159737 - bsearch usage
bsearch usage
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.5.x
Other Solaris
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2004-11-28 18:07 UTC by Morten Welinder
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morten Welinder 2004-11-28 18:07:59 UTC 
Solaris' bsearch will call the comparison function if the array is NULL and
the element count is zero.  This might be a solaris bug (and it is iff
NULL is a valid base pointer) and it is certainly rather stupid.

Unfortunately it causes a crash in alias_entry_cmp as called from
_xdg_mime_alias_list_lookup.

Suggested work-around: test for zero elements.
Comment 1 Matthias Clasen 2004-11-29 05:13:14 UTC 
On what does it call the comparison function if array is NULL ?!
If there are no elements, how can a test for zero elements help ?
Comment 2 Morten Welinder 2004-11-29 14:21:27 UTC 
The solaris bsearch code just isn't prepared for getting zero elements.
With NULL it will call the comparison function with NULL.

  if (list->n_aliases == 0)
    return NULL;

in _xdg_mime_alias_list_lookup will help because it won't ever enter
bsearch.
Comment 3 Matthias Clasen 2004-11-29 15:41:11 UTC 
2004-11-29  Matthias Clasen  <mclasen@redhat.com>

	* xdgmimeparent.c (_xdg_mime_parent_list_lookup): 
	* xdgmimealias.c (_xdg_mime_alias_list_lookup): Protect 
	against stupid bsearch() implementations.  (#159737,
	Morten Welinder)