After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159423 - Alert Role is missing for some dialog
Alert Role is missing for some dialog
Status: RESOLVED FIXED
Product: gnopernicus
Classification: Deprecated
Component: GUI
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Alexandra Telescu
Alexandra Telescu
Depends on:
Blocks:
 
 
Reported: 2004-11-25 10:48 UTC by Oana Serb
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (15.05 KB, patch)
2004-12-16 12:24 UTC, Alexandra Telescu 		none Details | Review
new proposed patch (913 bytes, patch)
2004-12-16 14:21 UTC, Alexandra Telescu 		none Details | Review
rewritten patch in current code style (921 bytes, patch)
2004-12-16 14:37 UTC, Alexandra Telescu 		committed Details | Review

Description Oana Serb 2004-11-25 10:48:05 UTC 
Log in as a user who doesn't have the gconf accessibility key set.
Start gnopernicus.
A dialog asking the user to set this key will be displayed.
On this dialog press the "Enable Support" button.
In this case a new dialog will be displayed.
These dialogs should have the "alert" role.
Comment 1 Alexandra Telescu 2004-12-16 12:24:53 UTC 
Created attachment 34891 [details] [review]
proposed patch
Comment 2 bill.haneman 2004-12-16 12:34:01 UTC 
Ada, I think this could be done without moving the dialogs from glade2; I think
you could call atk_stateset_add_state () on the dialogs before they are posted.
Comment 3 Dragan Sarbut 2004-12-16 12:48:51 UTC 
Mybe this will work as well :

AtkObject *obj = gtk_widget_get_accessible (dlg);
atk_object_set_role (ATK_ROLE_ALERT);
Comment 4 bill.haneman 2004-12-16 13:30:25 UTC 
Ada, you are right, I forgot for a moment that this is a ROLE and not a STATE. 
I believe the call above would work fine.  It should make a smaller patch! :-)
Comment 5 Alexandra Telescu 2004-12-16 14:21:48 UTC 
Created attachment 34897 [details] [review]
new proposed patch
Comment 6 bill.haneman 2004-12-16 14:28:49 UTC 
Patch looks good - some formatting/style issues only (please remember to put
spaces after commas, and before parentheses (

thanks!

Bill
Comment 7 Alexandra Telescu 2004-12-16 14:37:01 UTC 
Created attachment 34899 [details] [review]
rewritten patch in current code style
Comment 8 Dana Ormenisan 2004-12-17 09:20:36 UTC 
Comment on attachment 34899 [details] [review]
rewritten patch in current code style

The patch was applied in CVS HEAD and gnome-2-8 branch.