After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 158450 - Criawips cannot save files
Criawips cannot save files
Status: RESOLVED FIXED
Product: criawips
Classification: Deprecated
Component: general
0.0.x
Other All
: High major
: 0.1.0
Assigned To: Ezequiel Pérez
Sven Herzberg
Depends on:
Blocks:
 
 
Reported: 2004-11-16 13:23 UTC by Sven Herzberg
Modified: 2005-01-31 18:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The work I've done up to 17-11-04 (10.08 KB, application/x-bzip)
2004-11-18 19:06 UTC, Ezequiel Pérez
  Details
Criawips save patch (55.59 KB, patch)
2004-11-24 19:47 UTC, Ezequiel Pérez
none Details | Review
Missing file from previous patch (1.49 KB, application/octet-stream)
2004-11-24 19:57 UTC, Ezequiel Pérez
  Details
criawips-save-patch (17.07 KB, patch)
2004-11-25 17:27 UTC, Ezequiel Pérez
none Details | Review
criawips-save-WIP2.patch (27.11 KB, patch)
2004-11-26 19:48 UTC, Ezequiel Pérez
none Details | Review
Commented version of the patch (14.52 KB, text/plain)
2004-11-29 11:46 UTC, Sven Herzberg
  Details
presentation-writer-patch5 (14.86 KB, patch)
2005-01-07 23:08 UTC, Ezequiel Pérez
none Details | Review
presentation-writer-patch5-r1 (14.88 KB, patch)
2005-01-07 23:28 UTC, Ezequiel Pérez
none Details | Review
presentation-writer-patch6 (15.55 KB, patch)
2005-01-26 12:13 UTC, Ezequiel Pérez
none Details | Review
presentation-writer-patch-r7 (15.79 KB, patch)
2005-01-31 13:41 UTC, Ezequiel Pérez
none Details | Review

Description Sven Herzberg 2004-11-16 13:23:33 UTC
Criawips should be able to save modifications to files.
Comment 1 Ezequiel Pérez 2004-11-18 19:06:07 UTC
Created attachment 33913 [details]
The work I've done up to 17-11-04
Comment 2 Ezequiel Pérez 2004-11-24 19:47:45 UTC
Created attachment 34099 [details] [review]
Criawips save patch
Comment 3 Ezequiel Pérez 2004-11-24 19:57:00 UTC
Created attachment 34100 [details]
Missing file from previous patch
Comment 4 Sven Herzberg 2004-11-24 21:35:44 UTC
Committed most of the code, please make it work more robust and add the missing
functionality.
Comment 5 Ezequiel Pérez 2004-11-25 17:27:40 UTC
Created attachment 34132 [details] [review]
criawips-save-patch

Things are getting better, a lot improved, but still doesn't works as it is
meant to
Comment 6 Ezequiel Pérez 2004-11-26 19:48:56 UTC
Created attachment 34168 [details] [review]
criawips-save-WIP2.patch
Comment 7 Sven Herzberg 2004-11-29 11:46:52 UTC
Created attachment 34265 [details]
Commented version of the patch

This is a commented version of the patch, please try to fix outstanding issues,
I'd like to see that code in criawips then.
Comment 8 Ezequiel Pérez 2005-01-07 23:08:32 UTC
Created attachment 35638 [details] [review]
presentation-writer-patch5

Don't know if it compiles against current cvs
Comment 9 Ezequiel Pérez 2005-01-07 23:28:39 UTC
Created attachment 35641 [details] [review]
presentation-writer-patch5-r1

functions made static
Comment 10 Ezequiel Pérez 2005-01-26 12:13:49 UTC
Created attachment 36549 [details] [review]
presentation-writer-patch6

doesn't segfault
Comment 11 Sven Herzberg 2005-01-26 15:05:18 UTC
please adjust the indentation and the line breaks to match the other source
files of criawips, i'd like to commit the patch then
Comment 12 Ezequiel Pérez 2005-01-31 13:41:59 UTC
Created attachment 36761 [details] [review]
presentation-writer-patch-r7

This version fixes identation issues
Comment 13 Sven Herzberg 2005-01-31 18:05:52 UTC
2005-01-31 18:06  Sven Herzberg  <herzi@gnome-de.org>

        * src/presentation-writer.c,
        * src/presentation-writer.h: updated to a new file writer
        * src/presentation.c,
        * src/presentation.h: added a get_themes() method
        * src/theme.c,
        * src/theme.h: added a get_master_slides() method
        Patch fixes #158450; provided by Ezequiel Pérez