After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 157066 - Dragging files in the playlist doesn't change ->current
Dragging files in the playlist doesn't change ->current
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 72043
Blocks:
 
 
Reported: 2004-11-01 19:03 UTC by fps
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
totem-playlist-update-current.patch (3.57 KB, patch)
2004-11-16 00:12 UTC, Bastien Nocera 		none Details | Review

Description fps 2004-11-01 19:03:19 UTC 
1) open totem and add several files to the playlist
2) start playing a file
3) drag the currently playing file elsewhere within the playlist
4) let the track finish playing

You'll notice that there are now two "now playing" indicators
(http://derf.us/screendata/silicon/2004-11-01-13-44-35.jpg) and that the wrong
track is now playing.  One would expect that the track following the currently
playing track would be played next, even after that track is moved, however the
track following where the currently playing track was before the move is the
next one played.
Comment 1 Bastien Nocera 2004-11-04 23:25:51 UTC 
The problem is that we don't change the "current" pointer to point to the
currently playing track, if it's changed place in the treeview.
I'll check this bug when I'm not hit by the Xlib DND hang anymore.
Comment 2 Bastien Nocera 2004-11-16 00:12:22 UTC 
Created attachment 33824 [details] [review]
totem-playlist-update-current.patch

This patch is supposed to work, but as you can see if you run it, the
GtkTreeRowReference is not valid after the reorder, which is indeed pretty
broken and bizarre.
Comment 3 Bastien Nocera 2004-11-19 09:02:17 UTC 
Update dependency.
Comment 4 Bastien Nocera 2004-11-19 16:05:35 UTC 
Worked around the GtkTreeRowReference bug.

2004-11-19  Bastien Nocera  <hadess@hadess.net>
                                                                               
        * src/totem-playlist.c: (totem_playlist_set_reorderable),
        (button_press_cb), (button_release_cb), (drag_end_cb): work-around
        the GtkTreeRowReference not surviving a drag'n'drop (bug #72043)
        and keep track of the ->currently playing file (Closes: #157066)