After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156219 - Default colors should be from GNOME HIG palette
Default colors should be from GNOME HIG palette
Status: RESOLVED INVALID
Product: gnome-applets
Classification: Other
Component: modemlights
git master
Other All
: Normal trivial
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-10-23 15:25 UTC by spark
Modified: 2005-01-09 08:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to change default colors (4.01 KB, patch)
2004-10-23 15:31 UTC, spark
none Details | Review
Screenshot of colour changes (9.89 KB, image/png)
2004-10-24 15:44 UTC, spark
  Details
Screenshot of modem lights colours changes (5.90 KB, image/png)
2004-10-24 15:45 UTC, spark
  Details

Description spark 2004-10-23 15:25:39 UTC
The default colors are currently very bright and don't really fit
well with the GNOME desktops' more muted shades. 

Colors from the GNOME palette -
http://developer.gnome.org/projects/gup/hig/2.0/design.html#design-color -
should be used.
Comment 1 spark 2004-10-23 15:31:31 UTC
Created attachment 32962 [details] [review]
Patch to change default colors

Makes the default colors the following:

Receive Foreground: Accent Red
Receive Background: Red Shadow

Send Foreground: Accent Green*
Send Background: Green Shadow

Connected Status: Accent Green*
Disconnected Status: Green Shadow
Connecting Status: Accent Yellow

Text Foreground: Accent Green*
Text Outline: Green Shadow

* The "Accent Green" is lightened a little as suggested in the HIG to increase
the contrast for readablilty of the text.

This patch also fixes the text background color which was set to an invalid
value causing it the appear purple in prefs.
Comment 2 Danielle Madeley 2004-10-24 04:31:39 UTC
Can you attach a screenshot of these changes please?
Comment 3 spark 2004-10-24 15:44:31 UTC
Created attachment 32998 [details]
Screenshot of colour changes
Comment 4 spark 2004-10-24 15:45:37 UTC
Created attachment 32999 [details]
Screenshot of modem lights colours changes

Try to get the right screenshot in the right bug this time :)
Comment 5 Bryan W Clark 2004-10-25 03:03:09 UTC
Davyd had brought up possible readability issues with the new color palette
here, but I'll let him comment on that if he wants to.  I don't really see
those, but perhaps one has to run the applets in order to be able to tell. 
Personally I think following the HIG here is a plus since it reduces the
blinking of high contrast colors in the applets on the panel, especially applets
like this with lots constant activity.
Comment 6 Danielle Madeley 2004-10-25 12:42:52 UTC
I agree the muted colours are a plus. However, the lack of contrast between the
characters and the unlit cells makes reading hard.

Perhaps use the old unlit text colour.
Comment 7 spark 2004-10-25 15:27:15 UTC
Hmm... actually perhaps the unlit text pref should be dropped altogether since
it just makes it harder to read?

(as an aside, the text should prolly just be normal text like the weather applet...)
Comment 8 Danielle Madeley 2004-10-26 00:43:05 UTC
spark,

I tend to agree the text should be turned into normal text. To be perfectly
honest, I want to completely overhaul this applet and bring it up to date with
the other applets on the desktop.

To start with, that means removing the pages of god aweful preferences. Now I'm
not sure if this means that we should integrate it's functionality into
something else (like gnome-netstatus) or just simply redesign it. I'm tempted to
vote for redesigning it, perhaps you could lend a hand?

I'm after something simple, non-complicated and most of all usable!
Comment 9 Tuomas Kuosmanen 2004-10-27 05:02:59 UTC
It would sound most useful if we had a network selector applet
(wavelan/eth/modem) with all this functionality merged - you basically want to
see if bits are moving back and forth on your network device, be it modem or
ethernet or tcp-over-pigeons :) It might be a status icon instead of an applet
though - although I agree with people who are scared that everything will be a
status icon soon :) - but basically this thingy should show up whenever you
configure a network device or more, and should offer a way for the user to
switch those configured settings via a menu. That would be useful.

I like the new colours too. Another one to tackle wiht the hig palette would be
the cpu monitor applet unless it's already been taken care of.
Comment 10 spark 2004-10-27 12:27:25 UTC
Yeah, i suppose net-applet is basically what we're looking for (but with flashy
icons like Windows uses instead of a plain icon).
Comment 11 Danielle Madeley 2004-10-31 02:42:51 UTC
gnome-netstatus has flashy icons ;)
Comment 12 Danielle Madeley 2005-01-09 08:53:02 UTC
modemlights was rewritten for G10.