After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156150 - [PATCH] port about dialog from GnomeAbout to GtkAbout
[PATCH] port about dialog from GnomeAbout to GtkAbout
Status: RESOLVED DUPLICATE of bug 166620
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-10-22 12:13 UTC by Diego González
Modified: 2005-02-15 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.05 KB, patch)
2004-10-22 12:14 UTC, Diego González
none Details | Review
new patch (3.01 KB, patch)
2004-10-24 11:58 UTC, Diego González
none Details | Review

Description Diego González 2004-10-22 12:13:23 UTC
por about dialog from GnomeAbout to GtkAbout
Comment 1 Diego González 2004-10-22 12:14:00 UTC
Created attachment 32921 [details] [review]
patch
Comment 2 Jens Finke 2004-10-23 10:56:55 UTC
Thanks for the patch. Two comments: 
* 1. Can an you make use of the property interface? I.e.
g_object_new(GTK_TYPE_ABOUT_DIALOG, "name", _("Eye of Gnome"), ..., NULL).
* 2. Please, acknowledge also the translators. 

Thanks.
Comment 3 Jens Finke 2004-10-23 14:09:42 UTC
Another note: Subsequent calls to the about dialog when closing the dialog with
the dialogs 'x' button before, will crash eog. 
Comment 4 Diego González 2004-10-24 11:58:01 UTC
Created attachment 32990 [details] [review]
new patch

Neither this patch nor the first one crash for me when closing it from the "x"
frame window button
Comment 5 Jens Finke 2004-10-25 06:07:54 UTC
Notice the "subsequent calls" phrase. It doesn't crash if you close it by the
'x' button, but if you then call the about dialog again.
Comment 6 Diego González 2004-10-25 08:52:21 UTC
i have called the about dialog and closed it using the "x" button about 5 times
by now, with no crash.
Comment 7 Paolo Borelli 2005-02-15 14:54:35 UTC
I'm marking this as a dup of 166620 and not the other way round since the patch
in  166620 is better (it uses gtk_show_about_dialog).

*** This bug has been marked as a duplicate of 166620 ***