GNOME Bugzilla – Bug 156150
[PATCH] port about dialog from GnomeAbout to GtkAbout
Last modified: 2005-02-15 14:54:35 UTC
por about dialog from GnomeAbout to GtkAbout
Created attachment 32921 [details] [review] patch
Thanks for the patch. Two comments: * 1. Can an you make use of the property interface? I.e. g_object_new(GTK_TYPE_ABOUT_DIALOG, "name", _("Eye of Gnome"), ..., NULL). * 2. Please, acknowledge also the translators. Thanks.
Another note: Subsequent calls to the about dialog when closing the dialog with the dialogs 'x' button before, will crash eog.
Created attachment 32990 [details] [review] new patch Neither this patch nor the first one crash for me when closing it from the "x" frame window button
Notice the "subsequent calls" phrase. It doesn't crash if you close it by the 'x' button, but if you then call the about dialog again.
i have called the about dialog and closed it using the "x" button about 5 times by now, with no crash.
I'm marking this as a dup of 166620 and not the other way round since the patch in 166620 is better (it uses gtk_show_about_dialog). *** This bug has been marked as a duplicate of 166620 ***