After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 155427 - XGetKeyboardMapping call in reload_keymap() asks for wrong keycode_count
XGetKeyboardMapping call in reload_keymap() asks for wrong keycode_count
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.8.x
Other Linux
: High normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2004-10-14 21:17 UTC by Elijah Newren
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Request correct number of keycodes. (766 bytes, patch)
2004-10-14 21:18 UTC, Elijah Newren 		accepted-commit_now Details | Review

Description Elijah Newren 2004-10-14 21:17:41 UTC 
As reported by Rob in bug 129918, the correct number of keycodes to request from
XGetKeyboardMapping is max_keycode - min_keycode + 1.  See also
http://tronche.com/gui/x/xlib/input/XGetKeyboardMapping.html .  I will attach a
patch momentarily that fixes this.
Comment 1 Elijah Newren 2004-10-14 21:18:21 UTC 
Created attachment 32618 [details] [review]
Request correct number of keycodes.
Comment 2 Havoc Pennington 2004-10-15 22:02:30 UTC 
Comment on attachment 32618 [details] [review]
Request correct number of keycodes.

Should go on both branches.
Comment 3 Elijah Newren 2004-10-15 22:44:10 UTC 
committed to both branches.