GNOME Bugzilla – Bug 154388
gtkfilechooserbutton default button
Last modified: 2011-02-04 16:17:18 UTC
The GtkFileChooserButton's GtkFileChooserDialog's default accept button text is
"OK", which is contrary to the HIG.
I'm not too sure if it should say "Select", or if it should depend on the mode
of the file chooser ("Open" in ACTION_OPEN mode, etc.).
Every other selection dialog in GTK+ uses OK/Cancel, so I'm thinking that if
we're going to change this we should also change the other selectors as well.
The issue with "Open" and "Save" is that the app may or may not immediately open
or save the file represented by the button, so hitting "Open" or "Save" won't
actually open or save anything when the user clicks it. "Select" is generic
enough, but the user is already "selecting" something when they pick the
file/folder from the treeview in the actual GtkFileChooserWidget.
Another alternative is to simply ditch Ok/Cancel and just use "Close" -- which
should simplify the code a bit internally, and is the real HIG way (if the app
want's to hold off on instant-apply, the button should be in something with a
$NO/$YES pair of it's own anyways).
Fixed in CVS HEAD ("Save" for SAVE/CREATE_FOLDER, "Open" for OPEN/SELECT_FOLDER).