GNOME Bugzilla – Bug 153966
Prelight states for NotebookExtension
Last modified: 2014-01-25 02:25:23 UTC
While theming I noticed that there is no possibility to have a Prelight state for NotebookExtensions. Now I notice, that the GtkNotebook seems to be one object only, but maybe there is a way to change this, or hack around this.
Any update on this? I find this to be a nice feature since it makes applications consistent and appear to be more responsive. It doesn't seem to make sense when I mouse over a button and it hightlights but I mouse over a tab and it doesn't (tabs look like buttons to users).
Still no word? Is prelighting on tabs a worthy feature (I think so)? If I made a patch for this would it possibly be accepted? Is there someone that would help me out a little if I couldn't figure out how something worked?
Since the bug isn't marked WONTFIX, there is a possibility
Created attachment 45566 [details] [review] A patch Patch to do tab prelighting.
Do we want to have prelighting unconditionally for all notebooks ? There doesn't seem to be a way to theme the prelighting away, is there ?
The patch doesn't work with window widgets in the tabs, so I marked it rejected for that reason. To do this properly some sort of global motion events is required.
I don't think it matters that prelight doesn't work for window-widgets. Clicking inside those widgets will not focus that tab and prelighting would indicate that. I'm not sure what the use cases for window-widgets inside tab labels are though, besides close buttons. Any examples where it'd matter? And I'm not sure I'd prelight the selected tab - that should probably be decided by looking at similar cases in other widgets. Do selected items get prelight or not?
Here is my patch doing the same thing via adding a style property, which can be freely turn off, and doesn't add prelight unconditionally. http://bugzilla.gnome.org/attachment.cgi?id=66697&action=view This is included in bug#340203 http://bugzilla.gnome.org/show_bug.cgi?id=340203
*** Bug 616441 has been marked as a duplicate of this bug. ***
Why not make notebook extensions and menu bar buttons GtkToggleButton subclasses (i.e. an GtkBox of toggleButtons)? This would give prelighting for free, remove some code and make it all more straightforward.