After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 153657 - make typefind prevent unneeded discont element
make typefind prevent unneeded discont element
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: High blocker
: 0.8.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2004-09-24 17:13 UTC by Ronald Bultje
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch as described above (7.36 KB, patch)
2004-09-24 17:13 UTC, Ronald Bultje
none Details | Review
revision (8.35 KB, patch)
2004-09-25 13:52 UTC, Ronald Bultje
none Details | Review

Description Ronald Bultje 2004-09-24 17:13:00 UTC
2004-09-24  Ronald S. Bultje  <>

       * gst/elements/gsttypefindelement.c: (stop_typefinding),
       * gst/elements/gsttypefindelement.h:
         Prevent output of discont events after typefinding. Typefind
         will seek until the position of its internal bufferstore size
         and then act as an identity. However, filesrc, gnomevfssrc or
         any other seekable element will send a discont before this, and
         this breaks a surprising amount of elements (including, but not
         limited to, avidemux, asfdemux and matroskademux). This patch
         makes typefind filter out this discont event. Has been tested
         with both seekable and non-seekable elements and has the correct
         behaviour in both cases. Also fixes the mentioned demuxers in
         pipelines with typefind.
Comment 1 Ronald Bultje 2004-09-24 17:13:31 UTC
Created attachment 31914 [details] [review]
patch as described above
Comment 2 Ronald Bultje 2004-09-24 19:03:56 UTC
Avidemux (and sometimes matroskademux) experiences hangs after this patch; on
the other hand, asfdemux, matroskademux and qtdemux are all fixed and several
media files that failed previously in a player now work fine.

I'd suggest to wait before applying this patch (i.e. not 0.8.6). There's
probably something small wrong in it.
Comment 3 Ronald Bultje 2004-09-25 13:52:32 UTC
Created attachment 31933 [details] [review]

This revises the sending of buffers downstream. The first patch would send the
first buffer and then wait for the discont to come in. This is a race
condition, because, while we are waiting for this event, a downstream element
might seek further. This caused the hangs in avidemux and matroskademux. This
revision delays the sending of the first data until the discont has arrived.
This fixes the hangs in avidemux and matroskademux.
Comment 4 Ronald Bultje 2004-09-25 13:53:02 UTC
So, I'll try again, this patch doesn't fail any testcase that I can think of
anymore, I'd like this in 0.8.6...
Comment 5 Ronald Bultje 2004-10-01 11:57:56 UTC
This was applied to the release, we can now close this.