GNOME Bugzilla – Bug 153594
Accelerators in popup menu are not displayed
Last modified: 2006-05-16 07:11:35 UTC
Forward from bug http://qa.mandrakesoft.com/show_bug.cgi?id=11542 1/Run totem 2/Right click on video window => Items in popup menu don't display any accelerator and you get a bunch of the following warnings : (totem:6216): Gtk-CRITICAL **: file ../../gtk/gtkaccelgroup.c: line 267 (gtk_accel_group_find): assertion `GTK_IS_ACCEL_GROUP (accel_group)' failed (totem:6216): Gtk-CRITICAL **: file ../../gtk/gtkaccelgroup.c: line 267 (gtk_accel_group_find): assertion `GTK_IS_ACCEL_GROUP (accel_group)' failed (totem:6216): Gtk-CRITICAL **: file ../../gtk/gtkaccelgroup.c: line 267 (gtk_accel_group_find): assertion `GTK_IS_ACCEL_GROUP (accel_group)' failed (totem:6216): Gtk-CRITICAL **: file ../../gtk/gtkaccelgroup.c: line 267 (gtk_accel_group_find): assertion `GTK_IS_ACCEL_GROUP (accel_group)' failed (totem:6216): Gtk-CRITICAL **: file ../../gtk/gtkaccelgroup.c: line 267 (gtk_accel_group_find): assertion `GTK_IS_ACCEL_GROUP (accel_group)' failed (totem:6216): Gtk-CRITICAL **: file ../../gtk/gtkaccelgroup.c: line 267 (gtk_accel_group_find): assertion `GTK_IS_ACCEL_GROUP (accel_group)' failed (totem:6216): Gtk-CRITICAL **: file ../../gtk/gtkaccelgroup.c: line 267 (gtk_accel_group_find): assertion `GTK_IS_ACCEL_GROUP (accel_group)' failed
The BT. I'm trying to reproduce this outside Totem...
+ Trace 50476
*** Bug 153705 has been marked as a duplicate of this bug. ***
There seems to be some memory corruption in my test case: ==17632== ==17632== Invalid read of size 4 ==17632== at 0x6439FA: gtk_accel_group_find (in /usr/lib/libgtk-x11-2.0.so.0.400.7) ==17632== by 0x64639B: gtk_accel_label_refetch (in /usr/lib/libgtk-x11-2.0.so.0.400.7) ==17632== by 0x6462B7: (within /usr/lib/libgtk-x11-2.0.so.0.400.7) ==17632== by 0x645B21: (within /usr/lib/libgtk-x11-2.0.so.0.400.7) ==17632== Address 0x1BE0A9F8 is 0 bytes inside a block of size 32 free'd ==17632== at 0x1B904FA1: free (vg_replace_malloc.c:153) ==17632== by 0x4636C3: g_free (in /usr/lib/libglib-2.0.so.0.400.0) ==17632== by 0x4DA6AA: g_type_free_instance (in /usr/lib/libgobject-2.0.so.0.400.0) ==17632== by 0x4C38F0: (within /usr/lib/libgobject-2.0.so.0.400.0) ==17632== ==17632== Invalid read of size 4 ==17632== at 0x4DE8D4: g_type_check_instance_is_a (in /usr/lib/libgobject-2.0.so.0.400.0) ==17632== by 0x643A12: gtk_accel_group_find (in /usr/lib/libgtk-x11-2.0.so.0.400.7) ==17632== by 0x64639B: gtk_accel_label_refetch (in /usr/lib/libgtk-x11-2.0.so.0.400.7) ==17632== by 0x6462B7: (within /usr/lib/libgtk-x11-2.0.so.0.400.7) ==17632== Address 0x1BE0A9F8 is 0 bytes inside a block of size 32 free'd ==17632== at 0x1B904FA1: free (vg_replace_malloc.c:153) ==17632== by 0x4636C3: g_free (in /usr/lib/libglib-2.0.so.0.400.0) ==17632== by 0x4DA6AA: g_type_free_instance (in /usr/lib/libgobject-2.0.so.0.400.0) ==17632== by 0x4C38F0: (within /usr/lib/libgobject-2.0.so.0.400.0)
*** Bug 146340 has been marked as a duplicate of this bug. ***
Looks like the bug is in libglade. Ignore the valgrind trace above, it's not related.
*** Bug 156977 has been marked as a duplicate of this bug. ***
*** Bug 158574 has been marked as a duplicate of this bug. ***
*** Bug 166742 has been marked as a duplicate of this bug. ***
Created attachment 37435 [details] popup-test.c
Created attachment 37436 [details] popup-test.glade
Created attachment 37437 [details] [review] patch This works around the problem.
Created attachment 37438 [details] [review] updated patch The last one wasn't correct.
That looks alright. But how about splitting the popup menu to its own .glade file instead of having to change the code? Otherwise, we'll have to parse the full totem.glade for every right-click.
2005-02-17 Bastien Nocera <hadess@hadess.net> * NEWS: upd * data/Makefile.am: * data/popup.glade: * data/totem.glade: * src/bacon-video-widget-xine.c: (bacon_video_widget_get_languages), (bacon_video_widget_get_subtitles): * src/totem-playlist.c: (totem_playlist_new): * src/totem-private.h: * src/totem.c: (totem_action_menu_popup), (totem_action_set_mrl_with_warning), (update_seekable), (on_open_location1_activate), (show_controls), (update_buttons), (totem_callback_connect), (main): Split off popup menu into its own glade file to work around the accelerators not appearing in it (based on patch from William Jon McCann <mccann@jhu.edu>) (Closes: #153594), mark the strings used for the interface loading for translation, don't call xine_get_spu_lang() when there's no file loaded to avoid a crash, use the right stock icons in the popup menu, have the default sensitivity in some popup menu items
*** Bug 167977 has been marked as a duplicate of this bug. ***
*** Bug 169578 has been marked as a duplicate of this bug. ***
*** Bug 300900 has been marked as a duplicate of this bug. ***
*** Bug 301878 has been marked as a duplicate of this bug. ***
*** Bug 303439 has been marked as a duplicate of this bug. ***
*** Bug 341915 has been marked as a duplicate of this bug. ***