After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 151664 - Purge timeout is never removed
Purge timeout is never removed
Product: gnome-session
Classification: Core
Component: gnome-session
Other All
: Urgent blocker
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Reported: 2004-09-02 02:44 UTC by Federico Mena Quintero
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch to remove the purge timeout. (2.37 KB, patch)
2004-09-02 02:51 UTC, Federico Mena Quintero
accepted-commit_now Details | Review

Description Federico Mena Quintero 2004-09-02 02:44:03 UTC
When adding a client, a timeout handler gets installed.  If client doesn't
register itself with the SM before the timer expires, then the client is moved
to the purge lists.

However, the timeout is *not* removed if the client is reincarnated in the
meantime.  Reincarnation frees the old client structure.  Thus, when the timeout
triggers, the callback accesses free()d memory.  The attached patch fixes this.

This patch also needs to go in the gnome-2-6 branch.
Comment 1 Federico Mena Quintero 2004-09-02 02:51:02 UTC
Created attachment 31196 [details] [review]
Patch to remove the purge timeout.
Comment 2 Mark McLoughlin 2004-09-03 08:42:31 UTC
Patch looks good Federico, I can't believe this is all it was in the end. Thanks
much :-)

One comment - it'd be nice to s/gtk_timeout_add/g_timeout_add/ while you're there.

Feel free to commit once you've got approval from the release team.
Comment 3 Mark McLoughlin 2004-09-03 08:56:32 UTC
Oh, and after the freeze it would be good to get the debuggin patch you put on
your blog committed
Comment 4 Federico Mena Quintero 2004-09-13 17:04:01 UTC
Committed to both the gnome-2-6 and HEAD branches.