GNOME Bugzilla – Bug 151261
Add a "background" property to the theme format
Last modified: 2006-10-07 17:11:24 UTC
See bug #150465 for the motivation. Background options should include: - standard GTK theme background (choice of states?) which covers what we do now - background as (A)RGB color
Could we not extend the existing colour spec to allow for alpha. For example something like 'gtk:bg[NORMAL]/80' for 50% opacity normal background.
Created attachment 31250 [details] [review] patch showing introduction of theme format versions, and this feature This patch adds theme format versioning, and also color/alpha attributes on frame_style. I haven't tested the patch at all, I just thought I'd write it to show the general approach that I want to take.
Extending the existing color spec is possible, yeah. It just seemed a bit inconsistent with how the rest of the theme format works. Generally speaking GDK doesn't include alpha in the color... I can't remember if owen considered that feature or bug.
Here's a diff from my current cvs checkout because I want to delete said checkout... I don't remember if this diff is different from the one I attached earlier. I just accidentally deleted the ChangeLog so the older diff has that advantage at least.
Created attachment 36137 [details] [review] maybe the same patch as before, minus changelog
updating per comments
This should go into metacity-theme-2, I'm assuming. I'm trying to work with the most recent patch attached to this bug, but it's failing when meta_frames_set_window_background() calls meta_core_get_frame_flags(): meta_display_lookup_x_window() in that call returns null. Am I doing something wrong here?
(I have found the answer to my own question.)
Fixed in metacity-theme-2. I had to assume that the actual line to implement alpha in attachment 36137 [details] [review] works, since my X server doesn't have an alpha channel. Other than that, it all works.
Fixed in HEAD!