After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 150890 - Unnecessarily added spaces in gnome-applets messages
Unnecessarily added spaces in gnome-applets messages
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: keyboard indicator (gswitchit)
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: 150905
 
 
Reported: 2004-08-23 22:43 UTC by Christian Rose
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.7/2.8

Attachments
Patch to remove the trailing spaces (1.70 KB, patch)
2004-08-24 11:30 UTC, Christian Rose 		none Details | Review

Description Christian Rose 2004-08-23 22:43:38 UTC 
#: gkb-new/descs/ES_Spanish-x86.keyprop.desktop.in.h:3
msgid "Spanish PC/AT 101 keyboard "

The space added to the end of this message looks unnecessary.

Please note that there is currently a string freeze.
Comment 1 Christian Rose 2004-08-23 22:45:40 UTC 
The same goes for this message:

#: gkb-new/descs/Hungarian-x86.keyprop.desktop.in.h:2
msgid "Hungarian PC/AT 101 keyboard "
Comment 2 Christian Rose 2004-08-23 22:49:15 UTC 
And this one:

#: gkb-new/descs/UK-x86.keyprop.desktop.in.h:2
msgid "UK PC/AT keyboard "
Comment 3 Danielle Madeley 2004-08-24 03:45:16 UTC 
I think this can be resolved after the freeze.
Comment 4 Christian Rose 2004-08-24 08:31:38 UTC 
These messages all already exist in their non-trailing-space form:

#: gkb-new/descs/presets.xml.in.h:176
msgid "Spanish PC/AT 101 keyboard"

#: gkb-new/descs/presets.xml.in.h:93
msgid "Hungarian PC/AT 101 keyboard"

#: gkb-new/descs/presets.xml.in.h:203
msgid "UK PC/AT keyboard"

Thus, it would actually be no string freeze breakage to remove the trailing
spaces, since it wouldn't affect translations in that the identical but
non-trailing-space messages already exist and are marked up for translation from
before the freeze. 

From a translator POV, all that would seem happen would be that there are three
messages less to translate (the variants with trailing spaces).
Comment 5 Danielle Madeley 2004-08-24 08:44:28 UTC 
Can you provide a patch please? Thanks.
Comment 6 Christian Rose 2004-08-24 11:29:40 UTC 
Sure. Patch coming.
Comment 7 Christian Rose 2004-08-24 11:30:19 UTC 
Created attachment 30891 [details] [review]
Patch to remove the trailing spaces
Comment 8 Danielle Madeley 2004-08-24 12:03:07 UTC 
Excellent, you've clarified what I thought. I've committed it because it all
looks great. Thanks for that.