After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 149380 - Show animated gif in radar map window
Show animated gif in radar map window
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
git master
Other All
: Normal normal
: 2.10
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: 154976
 
 
Reported: 2004-08-05 09:16 UTC by Per Thomas Jahr
Modified: 2005-01-09 05:22 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch against CVS HEAD to implement this feature (3.97 KB, patch)
2004-12-11 01:37 UTC, Jonathan Brandmeyer
needs-work Details | Review
Patch against release 2.8.1.1 (4.14 KB, patch)
2004-12-11 01:57 UTC, Jonathan Brandmeyer
none Details | Review
patch to CVS HEAD (4.11 KB, patch)
2005-01-06 15:11 UTC, Jonathan Brandmeyer
none Details | Review

Description Per Thomas Jahr 2004-08-05 09:16:52 UTC
It would be nice if the radar map window of the weather applet could show 
animated gif's (and maybe other animated formats as well). 

As an example take a look at the animated radar map from the Norwegian 
Meteorological Institute:
http://met.no/radar/sorost.html
Comment 1 Jonathan Brandmeyer 2004-12-11 01:37:29 UTC
Created attachment 34722 [details] [review]
Patch against CVS HEAD to implement this feature
Comment 2 Jonathan Brandmeyer 2004-12-11 01:42:12 UTC
I have written a patch against CVS HEAD to implement this feature.  It uses
GdkPixbufAnimation and GtkImage's built-in capability to use such an object to
do the rendering.  Please review and commit this in time for GNOME 2.10.

The feature works automatically.  Selecting "Enable radar map", "Enable custom
radar map", and providing a URL to an animated image is sufficient to use this
feature.

The patch was originally developed against gnome-applets 2.8.1.1, and I can
provide a patch for that release, if ya'll are willing to add it to the 2.8.x
series.
Comment 3 Jonathan Brandmeyer 2004-12-11 01:45:19 UTC
I have written a patch against CVS HEAD to implement this feature.  It uses
GdkPixbufAnimation and GtkImage's built-in capability to use such an object to
do the rendering.  Please review and commit this in time for GNOME 2.10.

The feature works automatically.  Selecting "Enable radar map", "Enable custom
radar map", and providing a URL to an animated image is sufficient to use this
feature.

The patch was originally developed against gnome-applets 2.8.1.1, and I can
provide a patch for that release, if ya'll are willing to add it to the 2.8.x
series.
Comment 4 Jonathan Brandmeyer 2004-12-11 01:57:38 UTC
Created attachment 34723 [details] [review]
Patch against release 2.8.1.1

Folks who want to backport this feature to the current release should apply
this patch to 2.8.1.1.
Comment 5 Danielle Madeley 2004-12-11 02:57:24 UTC
This looks pretty good. I'll test it properly later on. Thanks!
Comment 6 Luis Villa 2005-01-06 04:11:07 UTC
Cleaning up milestones. I sure hope this one makes feature freeze!
Comment 7 Danielle Madeley 2005-01-06 04:24:38 UTC
Comment on attachment 34722 [details] [review]
Patch against CVS HEAD to implement this feature

I had forgotten about this. It has bitrotted somewhat, so will need updating.
Should be an easy fix.
Comment 8 Jonathan Brandmeyer 2005-01-06 15:11:40 UTC
Created attachment 35553 [details] [review]
patch to CVS HEAD

bitrot ... grumble grumble
Comment 9 Danielle Madeley 2005-01-09 05:22:46 UTC
This still seemed a bit bitrotten, but I managed to get it fixed up and committed.

Thanks for your hard work.