GNOME Bugzilla – Bug 149366
launched windows that don't get focus occur in wrong location in mru_list
Last modified: 2004-12-22 21:47:04 UTC
1. Launch an application 2. Click in another window before the application from step 1 is mapped 3. Wait for the application in step 1 to be mapped 4. Decide that you really do want to use the application launched in step 1 5. Use Alt-Tab or Alt-Esc Note that you have to alt-tab or alt-esc through ALL the windows on the current workspace in order to get to the launched application. A single press of alt-tab or alt-esc should suffice. In other words, if the launched app doesn't get focus, we should make it appear in the mru list just after the window with focus.
Created attachment 30224 [details] [review] patch to make launched windows denied focus appear in mru list after the focused window The function actually provides two implementations. One is untested but easier to understand. I didn't use that method because it'd have to loop through the entire mru_list more than once, when I expect the two windows of interest to be the first two entries in the mru_list.
Marking this bug as blocking 149028, since bug 149028 is the summary of all remaining bugs about _NET_WM_USER_TIME.
Thanks, the slow/simple implementation is probably better in this case, speed hardly matters. You might add a comment "this is slow, but doesn't matter while we're only using it on new window map" Also, split variable declaration from assignment: GList *foo; foo = g_list_find ()
Created attachment 30243 [details] [review] simpler version, with bugfix Okay, here's a patch that just uses the simpler yet slower version. It also fixes a bug in a (very common) situation that I hadn't thought of and hadn't previously tested. Alright to apply?
Comment on attachment 30243 [details] [review] simpler version, with bugfix Looks good to me
applied.