After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 149304 - ORBit2/linc2/src/cleanup.c
Product: ORBit2
Classification: Deprecated
Component: general
Other All
: Normal normal
: ---
Assigned To: ORBit maintainers
ORBit maintainers
Depends on:
Reported: 2004-08-04 17:07 UTC by Morten Welinder
Modified: 2006-07-24 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch to use $TMPDIR instead of hardcoding /tmp (341 bytes, patch)
2005-07-08 14:57 UTC, Sebastian Rittau
none Details | Review

Description Morten Welinder 2004-08-04 17:07:47 UTC
1. This should not be a separate program, but something done on startup.
   (Perhaps not every time, but say once a day.)

2. Don't hardcode /tmp/, use $TMPDIR if present.

3. Don't use g_snprintf.  If the filename is too long, return SOCKET_DEAD_NOW
   because ORBIT didn't create those.

4. Don't even think of g_assert.  There are plenty of reasons why socket
   could fail.  Solaris' man page lists EACCES, EMFILE, ENOMEM, ENOSR
   that seem to all apply.  I would guess they forgot ENOENT.
Comment 1 Sebastian Rittau 2005-07-08 14:57:24 UTC
Created attachment 48830 [details] [review]
patch to use $TMPDIR instead of hardcoding /tmp

This patch fixes the problem that linc-cleanup-sockets looks in /tmp for
sockets to clean, while it should use $TMPDIR.
Comment 2 Michael Meeks 2005-07-08 15:15:49 UTC
please do commit & thanks :-)
Comment 3 Michael Meeks 2005-07-08 15:16:08 UTC
also  d-bus cut/pasted this code, you might want to check there too.
Comment 4 Sebastian Rittau 2005-07-08 23:01:33 UTC
Commited to HEAD, checking dbus now.
Comment 5 Kjartan Maraas 2006-07-24 13:35:38 UTC
dbus seems to take the dir from the commandline. Closing this here.