GNOME Bugzilla – Bug 149304
Last modified: 2006-07-24 13:35:38 UTC
1. This should not be a separate program, but something done on startup.
(Perhaps not every time, but say once a day.)
2. Don't hardcode /tmp/, use $TMPDIR if present.
3. Don't use g_snprintf. If the filename is too long, return SOCKET_DEAD_NOW
because ORBIT didn't create those.
4. Don't even think of g_assert. There are plenty of reasons why socket
could fail. Solaris' man page lists EACCES, EMFILE, ENOMEM, ENOSR
that seem to all apply. I would guess they forgot ENOENT.
Created attachment 48830 [details] [review]
patch to use $TMPDIR instead of hardcoding /tmp
This patch fixes the problem that linc-cleanup-sockets looks in /tmp for
sockets to clean, while it should use $TMPDIR.
please do commit & thanks :-)
also d-bus cut/pasted this code, you might want to check there too.
Commited to HEAD, checking dbus now.
dbus seems to take the dir from the commandline. Closing this here.