After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 149201 - Disabled item name in File Properties can not be selected
Disabled item name in File Properties can not be selected
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
2.6.x
Other All
: High minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 131190 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-08-03 19:03 UTC by Vidar Braut Haarr
Modified: 2005-05-22 14:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
Proposed patch (10.01 KB, patch)
2005-03-27 16:55 UTC, Michael Terry
none Details | Review
better patch (10.12 KB, patch)
2005-04-04 20:14 UTC, Michael Terry
committed Details | Review

Description Vidar Braut Haarr 2004-08-03 19:03:23 UTC
1. Mount a CD
2. Right-click on it and select Properties
3. Try to select its name with the mouse or keyboard.

Expected results:
As per the HIG at
<http://developer.gnome.org/projects/gup/hig/2.0/controls-sensitivity.html#controls-locked>,
where it states (at the far bottom of the page):
"Note that although they cannot be edited, the settings are still visible and
selectable, and may be copied to the clipboard."
it should be possible to highlight the text and copy it.

Actual results:
I can't give focus to the textfield at all.


Sorry, I'm not sure this should be in "Accessibility" - my first guess was
"Metadata", but after looking through the bugs there I wasn't sure.
Please triage :)
Comment 1 Michael Terry 2005-03-27 16:55:51 UTC
Created attachment 39309 [details] [review]
Proposed patch

This is a patch to solve this problem and also whack a FIXME requesting this in
the code.  This patch replaces the entry bar with a selectable label if the
properties window is for multiple files or a file that you can't rename.

There are a couple problems with it:

1) When examining multiple files, if the filenames are longer than window, it
will be ellipsized, preventing you from looking at the list of filenames.  I
don't know how big a deal this is, or what the solution would be.

2) I didn't make it dynamically change the label for the "_Name:" label, which
means that if you have a file you can't rename, there will be a mnemonic for
the label which can't be used.

I think it looks a lot better than before.  I had difficulty testing the
on-the-fly swapping of widgets if you lose or gain renaming rights due to my
FAM setup.  Please test.
Comment 2 Michael Terry 2005-03-27 16:56:29 UTC
Bumping priority.
Comment 3 Sebastien Bacher 2005-03-27 18:24:42 UTC
why do you change the priority ?
Comment 4 Michael Terry 2005-03-27 21:11:15 UTC
I thought it was GNOME bugzilla policy to have High priority on bugs with
patches (http://developer.gnome.org/projects/bugsquad/triage/steps.html - step 7).
Comment 5 Sebastien Bacher 2005-03-27 21:38:25 UTC
right :) Perhaps you could send the patch on the nautilus list too, maintainers
usually review patches here
Comment 6 Michael Terry 2005-04-04 20:14:45 UTC
Created attachment 39685 [details] [review]
better patch

Being notified of a couple warnings that my patch gave, I have modified it.  I
have also tested that it does correctly swap out widgets.

However, support for this is limited.  Limited to pre-patch support for it, at
any rate.  There is no easy way to monitor renamability.  Current nautilus will
not change the sensitivity of the name entry if the parent directory loses
write access.  It will only do so if you try to rename it and it finds you
can't.	My patch also does this, changing the entry to a label in that case.

At some point in the future, if monitoring renamability is possible, my patch
should make it easy, having the foundations for it.
Comment 7 Alexander Larsson 2005-04-05 08:55:01 UTC
commited. Thanks.
Comment 8 Martin Wehner 2005-05-22 14:22:51 UTC
*** Bug 131190 has been marked as a duplicate of this bug. ***