GNOME Bugzilla – Bug 148694
Adding a search path for icons
Last modified: 2004-12-22 21:47:04 UTC
At the moment, GTK+ is restricted to search for icons in one directory. This doesn't work for us. We install GTK+ in a *totally* separate directory from all other applications. In the process of building GNOME in a *totally* separate directory, we run into runtime issues with GNOME icons not being found. The GTK+ default icons are stored to /opt/TWWfsw/libgtk+24/share/icons and the GNOME icons to /opt/TWWfsw/gnome26/share/icons.
Created attachment 30004 [details] [review] Patch to implement feature GTK_PATH_ICONS selected as the environment variable. Dunno how appropriate it is but I had to pick something. The code is kinda ripped from get_module_path() in gtk/gtkmain.c
This needs to be done by implementing the xdg base dir spec for icon theme code.
I read the spec and it says to search $XDG_DATA_DIRS/icons. So, based on the patch I've submitted, looks like I only need to: 1. Rename GTK_PATH_ICONS to XDG_DATA_DIRS 2. Iterate over each $XDG_DATA_DIRS path component, append "/icons", and add it to priv->search_path. Correct?
Created attachment 30022 [details] [review] XDG_DATA_DIRS Patch Patch searching through $XDG_DATA_DIRS. Something I've done which you might not agree with is append both "/icons" and "/pixmaps" to $XDG_DATA_DIRS. The reason for this is that GNOME 2.6.x still installs images to $(datadir)/pixmaps. So, if GNOME 2.6.x is installed with --prefix=/usr/local, /usr/local/share/pixmaps won't be searched. Does "/icons" == "/pixmaps"?
This should probably use the xdg base dir api proposed by Ray in bug 139973
What is the status of accepting the patch in bug 139973? I'm happy to update my patch to use g_get_secondary_data_dirs().
I would appreciate an updated patch using g_get_user_data_dir() and g_get_system_data_dirs()
Nevermind, I went ahead and did this for cvs HEAD: 2004-08-17 Matthias Clasen <mclasen@redhat.com> * gtk/gtkicontheme.c (gtk_icon_theme_init): Look up icon themes in the directories specified in the icon theme spec: $HOME/.icons, $XDG_DATA_DIRS/icons, /usr/share/pixmaps. Note that GTK+ used to also look in $GTK_DATA_DIR/icons, $GTK_DATA_DIR/pixmaps and /usr/share/icons. (#148694)