GNOME Bugzilla – Bug 147666
Patch 'gnome-network-preferences' to add proxy exclusion list configuration
Last modified: 2005-01-23 18:50:06 UTC
Add a notebook to the main dialog. In the first tab are the usual configuration controls. In the second tab are the addition and remotion of the server exclusion list, used for the proxy configuration. By now this patch makes gnome-network-preferences a little bit unstable, but can be a start point.
Created attachment 29560 [details] [review] Add proxy server exclusion list configuration
This is not gnome-network, changing product/component
The patch is reasonable and I like the functionality. Lets get usability to sign off on the added complexity.
Any chance somebody could post a screenshot?
Created attachment 29701 [details] First notebook page (old configuration widgets)
Created attachment 29702 [details] Second notebook page (with ingore server list)
The design looks pretty solid, although personally I'd probably want to try and improve the tab labels a bit... the first is virtually the same as the window title, and "Advanced" isn't as helpful as it could be either. Stepping back a little, I wonder if we need to add this much complexity... Mozilla (for example) just has a single text field into which you can type a comma separated list, with an example underneath it to help. Admittedly that's more prone to user error, though, and doesn't allow you to see the whole list at once, so I guess this way is better.
Comment on attachment 29560 [details] [review] Add proxy server exclusion list configuration Lets get this in. We can tune the labels once the functionality lands.
Please mail release-team@gnome.org to get approval to break the feature freeze first.
The design looks pretty good and minus some label rewording I think it would be a good addition. If you're working more on this, just a future note, I think a combo box would be nice to include a possible list of proxy servers found via OpenTalk (the protocol formally known as rendezvous), as we have support for this protocol in gnome-vfs now, for both this exclusion list and the autoconfig entry on the first tab. Of course not all proxies support exporting their capability via OpenTalk just yet, but in our Brave New World(tm) that will change.
Nice suggestion. I won't work on it to soon, but in my spare time I can make something on it. I don't have any experience with OpenTalk. Even more the gnome-vfs implementation. If you could send any reference, I could take a look in that later. It would be nice to code on it. Just as advice, I noticed some segmentation fault here, after the modifications. I couldn't take a more close look on this problem, and it doesn't happens always. But the segfault always happens on the start of the app. If others could test it more... Well I'm very proud to contribute to Gnome" :)
Note that there is an alternative implementation, some bits might be interesting: http://lists.gnome.org/archives/usability/2004-October/msg00247.html
The first patch has been sitting in accepted-commit_now status since july. Can we please get this in CVS now polish the details after the functionality is in? Feature freeze is NOW!
Since it's got accepted-commit_now status, and got forgotten, I can't believe there would be any objections to anyone with a checked-out tree committing the patch. I'd do it myself, but I don't have a checked-out tree.
ok, I'll commit it
I've tried to commit it, but it doesn't apply to the current CVS neither in the 2004-07-15 head tree. Do you have a patch updated by any chance ? Merging the changes in the glade file is pretty long and I've messed up the glade file somewhere will doing it, I'll try again tomorrow.
ok, I've commited an updated patch to HEAD, thanks for the work! I've fixed 2 small bugs in it too: - in setup_dialog (): gtk_label_set_use_markup (GTK_LABEL (GTK_BIN (WID ("label_ignore_host"))), TRUE); the widget is a label so GTK_LABEL () is enough - in populate_listmodel (): gtk_list_store_set(store, &iter, 0, (char *) pointer->data); a "-1" is needed (it was getting some random arguments and crashing before)
*** Bug 44098 has been marked as a duplicate of this bug. ***