Bug 146653 – lot of errors and crash with "charset=CHARSET" in a po file

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 146653 - lot of errors and crash with "charset=CHARSET" in a po file


Summary:	lot of errors and crash with "charset=CHARSET" in a po file


Status:	RESOLVED FIXED

Product:	gtranslator
Classification:	Other
Component:	Generally bug'd
Version:	HEAD
Hardware:	Other other

Importance:	Normal critical
Target Milestone:	1.0
Assigned To:	Ross Golder
QA Contact:	Ross Golder

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2004-06-16 16:48 UTC by Sebastien Bacher
Modified:	2005-02-06 22:03 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix for this crash (1.34 KB, patch) 2005-02-03 20:36 UTC, Loïc Minier	none	Details \| Review

Description Sebastien Bacher 2004-07-09 08:21:41 UTC

Distribution: Debian testing/unstable
Package: gtranslator
Severity: critical
Version:  HEAD
Synopsis: lot of errors and crash with "charset=CHARSET" in a po file
Bugzilla-Product: gtranslator
Bugzilla-Component: Generally bug'd
Bugzilla-Version: HEAD
BugBuddy-GnomeVersion: 2.0 (2.6.1.1)
Description:
Description of the crash:
Try to open an iso-8859 po file with "charset=CHARSET" in the header

Steps to reproduce the crash:
1. open the file (it displays a lot of errors in the console)
2. close the info box without changing anything
3. close the file without saving it
4. try to open a new file

Expected Results:
1- don't display all these errors
2- don't crash

How often does this happen?
every time

Additional Information:



Debugging Information:

Backtrace was generated from '/usr/bin/gtranslator'

Using host libthread_db library "/lib/tls/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 1087404928 (LWP 12566)]
0x408a340e in __waitpid_nocancel () from /lib/tls/libpthread.so.0

+ Trace 48081

Thread 1 (Thread 1087404928 (LWP 12566))

#0 __waitpid_nocancel
from /lib/tls/libpthread.so.0
#1 libgnomeui_module_info_get
from /usr/lib/libgnomeui-2.so.0
#2 <signal handler called>
#3 strrchr
from /lib/tls/libc.so.6
#4 g_path_get_dirname
from /usr/lib/libglib-2.0.so.0
#5 gtranslator_file_dialogs_set_directory
at dialogs.c line 541
#6 gtranslator_open_file_dialog
at dialogs.c line 126
#7 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#8 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#9 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#10 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#11 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#12 gtk_button_clicked
from /usr/lib/libgtk-x11-2.0.so.0
#13 _gtk_button_paint
from /usr/lib/libgtk-x11-2.0.so.0
#14 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#15 g_cclosure_new_swap
from /usr/lib/libgobject-2.0.so.0
#16 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#17 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#18 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#19 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#20 gtk_button_released
from /usr/lib/libgtk-x11-2.0.so.0
#21 _gtk_button_paint
from /usr/lib/libgtk-x11-2.0.so.0
#22 _gtk_marshal_BOOLEAN__BOXED
from /usr/lib/libgtk-x11-2.0.so.0
#23 g_cclosure_new_swap
from /usr/lib/libgobject-2.0.so.0
#24 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#25 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#26 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#27 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#28 gtk_widget_send_expose
from /usr/lib/libgtk-x11-2.0.so.0
#29 gtk_propagate_event
from /usr/lib/libgtk-x11-2.0.so.0
#30 gtk_main_do_event
from /usr/lib/libgtk-x11-2.0.so.0
#31 _gdk_events_queue
from /usr/lib/libgdk-x11-2.0.so.0
#32 g_main_depth
from /usr/lib/libglib-2.0.so.0
#33 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#34 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#35 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#36 gtk_main
from /usr/lib/libgtk-x11-2.0.so.0
#37 main
at main.c line 527
#0 __waitpid_nocancel
from /lib/tls/libpthread.so.0





------- Bug moved to this database by unknown@bugzilla.gnome.org 2004-07-09 04:21 -------


Unknown platform unknown. Setting to default platform "Other".
Unknown milestone "unknown" in product "gtranslator".
   Setting to default milestone for this product, '1.0'
Setting to default status "UNCONFIRMED".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Elijah Newren 2004-10-31 05:10:45 UTC

*** Bug 152191 has been marked as a duplicate of this bug. ***

Comment 2 Loïc Minier 2005-02-03 20:36:33 UTC

Created attachment 36946 [details] [review]
Fix for this crash

This patch fixes the problem here, it basically changes the type of test used
to know whether we can rely on the current opened file to guess the current
directory, and adds safety checks for parameters and against reusal of freed
vars.

Comment 3 Ross Golder 2005-02-05 09:48:33 UTC

Patch applied to CVS. Thanks again.

Comment 4 Loïc Minier 2005-02-06 22:03:05 UTC

(Closing this bug after the release.)