After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 145596 - Miscellaneous clean-ups [patches]
Miscellaneous clean-ups [patches]
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
2.6.x
Other Linux
: High trivial
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-07-08 00:58 UTC by Alexey Spiridonov
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6



Description Alexey Spiridonov 2004-07-08 00:58:46 UTC
Eliminate some code bloat:

--- terminal-window.c-unpatched 2004-07-06 22:25:43.000000000 -0400
+++ terminal-window.c   2004-07-06 23:12:09.000000000 -0400
@@ -1401,15 +1532,9 @@
   {
     /* Match size to current active screen */
     int current_width, current_height;
-    GtkWidget *current_widget;
-
     if (window->priv->active_term)
-      current_widget = terminal_screen_get_widget (window->priv->active_term);
-    else
-      current_widget = NULL;
-    
-    if (current_widget)
-      terminal_widget_get_size (current_widget, &current_width, &current_height);
+      terminal_widget_get_size
(terminal_screen_get_widget(window->priv->active_term), 
+                                &current_width, &current_height);
     else
       {
         current_width = 80;

Another clean-up:

--- terminal-window.c-unpatched 2004-07-07 20:56:07.000000000 -0400
+++ terminal-window.c   2004-07-07 20:56:41.000000000 -0400
@@ -913,8 +913,6 @@
 
   mi = append_stock_menuitem (menu, GTK_STOCK_ZOOM_100, ACCEL_PATH_ZOOM_NORMAL,
                               G_CALLBACK (zoom_normal_callback), window);
-  /* the default label for GTK_STOCK_ZOOM_100 does not follow the HIG... */
-  set_menuitem_text (mi, _("_Normal Size"), FALSE);
   window->priv->zoom_normal_menuitem = mi;
   menuitem_icon_visibility (window->priv->zoom_normal_menuitem, menus_have_icons);
 
This no longer holds in 2.4.1 (and possibly before), GTK has a perfectly good
label there.
Comment 1 Mariano Suárez-Alvarez 2004-10-31 02:32:47 UTC
Commited the first one; the second part was alredy there.