After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 145276 - cannot add a song multiple times to a simple playlist
cannot add a song multiple times to a simple playlist
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 339075 369106 565522 569541 615532 623499 643030 657128 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-07-01 22:09 UTC by Sebastien Bacher
Modified: 2018-05-24 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastien Bacher 2004-07-01 22:09:33 UTC
This bug has been reported in the Debian BTS: http://bugs.debian.org/257086

"When I drag a song from the library onto a simple playlist, it will add 
the song to that playlist.  However, dragging the same song into the 
playlist again doesn't add a second copy; I am limited to one copy of a 
song in a playlist."
Comment 1 Alex Lancaster 2006-01-26 06:09:56 UTC
Confirming still present in CVS HEAD as of 2006-01-25.
Comment 2 James "Doc" Livingston 2006-01-26 11:41:11 UTC
Allowing multiple copies of a track would require changing the internals of RhythmDBQueryModel, so it isn't going to magically get fixed. Doing so would require changing it to no longer use reverse mappings (entry -> position) which would be difficult to do without suffering a large performance penalty.
Comment 3 Jonathan Matthew 2006-04-19 20:59:12 UTC
*** Bug 339075 has been marked as a duplicate of this bug. ***
Comment 4 James "Doc" Livingston 2006-04-20 00:54:09 UTC
A potential solution to this would be to create the "entry model" interface mentioned on bug 334884, and then separate the query-based model (including filtering) from the list-of-uris model. The latter could support having multiple instances of an entry in the list, as the reverse-mapping probably isn't as essential for that case.
Comment 5 Jonathan Matthew 2006-05-17 13:34:20 UTC
It's pretty easy to make the query model's hash table optional, then modify the static playlist class to use query models without the hash table.  I considered splitting the query model class up, but it didn't seem quite right.  I've got this working to the point where you can create a playlist (or play queue) containing the same song multiple times.

The remaining problem is that the play orders just store the current entry.  Things like rhythmdb_query_model_get_next_from_entry don't work properly when the same entry is present multiple times.  We should be able to use GtkTreeIters, I think, as long as we make sure we keep them up to date with the contents of the query model.
Comment 6 James "Doc" Livingston 2006-05-18 01:52:45 UTC
RhythmDBQueryModel current sets the "persistant iterators" flag to true (iterators are valid after model changes), so as long as you haven't made iterators non-persistant it should work.
Comment 7 Alex Lancaster 2006-11-02 01:47:23 UTC
*** Bug 369106 has been marked as a duplicate of this bug. ***
Comment 8 Sebastien Bacher 2006-12-17 14:41:06 UTC
Ubuntu bug about that: https://launchpad.net/products/rhythmbox/+bug/63587
Comment 9 Jonathan Matthew 2008-12-26 22:06:41 UTC
*** Bug 565522 has been marked as a duplicate of this bug. ***
Comment 10 Jonathan Matthew 2009-01-28 22:51:21 UTC
*** Bug 569541 has been marked as a duplicate of this bug. ***
Comment 11 Jonathan Matthew 2010-04-12 20:33:12 UTC
*** Bug 615532 has been marked as a duplicate of this bug. ***
Comment 12 Jonathan Matthew 2010-07-09 13:23:46 UTC
*** Bug 623499 has been marked as a duplicate of this bug. ***
Comment 13 Jonathan Matthew 2011-02-23 02:34:54 UTC
*** Bug 643030 has been marked as a duplicate of this bug. ***
Comment 14 Jonathan Matthew 2011-08-23 03:53:28 UTC
*** Bug 657128 has been marked as a duplicate of this bug. ***
Comment 15 Myk Dowling 2011-08-23 05:32:29 UTC
I understand this isn't going to "magically get fixed." 

It has now been seven years since it was first reported, though. Is it going to get fixed at all?
Comment 16 kerhunet 2011-11-29 02:32:42 UTC
I hope this bug was fix. I use Rythmbox for teaching Dance and i need to play many time the same song (i used the same playlist for the all the lesson).
I have the same problem to make playlist for "milonga" (argentin bal), i use many time the same song between different musical theme.
Comment 17 Santiago Gala 2011-12-13 00:21:02 UTC
The problem is still there, it looks like nobody will fix it.
Comment 18 Robert Balent 2012-11-14 00:37:17 UTC
Is here some progress about this bug? Or the code is so complicated that nobody dares to solve this?
Comment 19 Luís 2015-09-29 16:34:57 UTC
Eleven years on, this bug is still open. Could someone from the dev team update the user-ship on this? Thank you.
Comment 20 GNOME Infrastructure Team 2018-05-24 10:34:26 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/40.