After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 145191 - Gimpressionist Revamp Patch
Gimpressionist Revamp Patch
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on: 144913
Blocks:
 
 
Reported: 2004-06-30 13:53 UTC by Shlomi Fish
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Revision 43 of the Patch (101.19 KB, patch)
2004-06-30 13:56 UTC, Shlomi Fish
none Details | Review
Revision 52 of the Patch (124.27 KB, patch)
2004-07-02 13:01 UTC, Shlomi Fish
none Details | Review

Description Shlomi Fish 2004-06-30 13:53:36 UTC
This is a placeholder for the patch that heavily refactors Gimpressionist. 
Note that this patch includes the functionality provided by the rudimentary 
Gimpressionist PDB-enabling patch. (which in turn includes some bug-fixes) 
However, I'd recommend that people apply this patch only after the PDB one, 
to maintain consistency in the commits.
Comment 1 Shlomi Fish 2004-06-30 13:56:49 UTC
Created attachment 29114 [details] [review]
Revision 43 of the Patch

This is revision 43 of the patch. The code is in a better state that it was
when the process started, so it can be safely applied. However, there's more
coming, so you may wish to wait before applying it.

Note that building the modified code in a "make dist"ed version was not yet
tested.
Comment 2 Shlomi Fish 2004-07-02 13:01:47 UTC
Created attachment 29161 [details] [review]
Revision 52 of the Patch

This is a new patch. Most of the objectives for the initial refactoring have
been reached. One bug or two that were encountered and prevented further
refactoring were fixed. Let me (Shlomi Fish) know if you have any questions
about it. Unfortunately, I did not maintain a detailed changelog, nor did I
modify the gimpressionist one. I do have a series of the 52 head->private
version patches I prepared if you wish me to construct one.
Comment 3 Michael Natterer 2004-07-02 13:32:35 UTC
Fixed in CVS:

2004-07-02  Michael Natterer  <mitch@gimp.org>

	* plug-ins/gimpressionist/Makefile.am
	* plug-ins/gimpressionist/*.[ch]: applied patch from Shlomi Fish
	that massively cleans up gimppressionist (touching all files and
	addding some new ones) and adds a simple PDB interface for
	selecting one of the previously created presets.
	Fixes bugs #145191, #144913 and #144922.