After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144897 - Don't use CurrentTime to launch applications
Don't use CurrentTime to launch applications
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: File and Folder Operations
0.x.x [obsolete]
Other Linux
: High major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 149028
 
 
Reported: 2004-06-24 02:01 UTC by Elijah Newren
Modified: 2011-01-17 15:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
The wrong way to handle this problem (3.32 KB, patch)
2004-06-24 02:02 UTC, Elijah Newren 		committed Details | Review

Description Elijah Newren 2004-06-24 02:01:39 UTC 
libnautilus-private/nautilus-program-choosing.c uses CurrentTime to launch
applications.  Because of the patches that will soon be applied from bug 118372,
this means that these launched applications will not be focused and will appear
behind the focused window.  A timestamp from some event, such as a ButtonPress,
should be used instead.

I will attach a patch momentarily that provides the /wrong/ way to fix it, but
which is fully functional (i.e. so that annoyed users who run from CVS can have
something to use while they wait for the real fix).
Comment 1 Elijah Newren 2004-06-24 02:02:21 UTC 
Created attachment 28972 [details] [review]
The wrong way to handle this problem
Comment 2 Alexander Larsson 2004-06-24 16:42:55 UTC 
I applied this patch, but lets keep the bug open so we will fix it the right way. 

The right way is for all the launcher functions to take a timestamp argument,
and then propagate that backwards until it reaches the place where the user
event happened. As a start, we could use slowly_and_stupidly_obtain_timestamp if
you pass CurrentTime.
Comment 3 Elijah Newren 2004-10-14 16:27:33 UTC 
I'm going to mark this as blocking bug 149028 just so that I don't forget about it.
Comment 4 Martin Wehner 2005-01-20 08:27:33 UTC 
Comment on attachment 28972 [details] [review]
The wrong way to handle this problem

I marked the patch as committed to get it of the "unreviewed patches" radar.
Comment 5 Cosimo Cecchi 2011-01-17 15:23:33 UTC 
This should be history since we switched to GIO. Closing as OBSOLETE.