After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144772 - tab close button too small
tab close button too small
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2004-06-21 19:22 UTC by Christian Persch
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (3.34 KB, patch)
2004-09-02 19:38 UTC, Marco Pesenti Gritti 		accepted-commit_now Details | Review

Description Christian Persch 2004-06-21 19:22:30 UTC 
The tab label close buttons are too small after the recent gkt+ button
alloaction change.
Comment 1 Marco Pesenti Gritti 2004-06-21 19:28:22 UTC 
I think this is caused by a crazy hack epiphany/galeon/gedit are doing to have a
small button even if the close button image is big. I think we should use a
12x12 icon. If the icon theme one is too small when resized, then we need to
have our own close icon without border.
Comment 2 Marco Pesenti Gritti 2004-09-01 17:52:41 UTC 
Christian, didnt we solve this in some way ?
Comment 3 Christian Persch 2004-09-01 19:36:00 UTC 
IIRC our "solution" was to create a special stock mini-close-button icon that
wouldn't have so much blank space around it in the image itself (the normal
close stock item has too much blank space around the 'x').
Comment 4 Marco Pesenti Gritti 2004-09-02 19:38:01 UTC 
Created attachment 31218 [details] [review]
fix

Christian can you review ? I gave up on adding a 12x12 image to
gnome-icon-theme because 12 is still too much. With current code we are even
cutting part of the image, ugh.
Comment 5 Christian Persch 2004-09-02 20:19:01 UTC 
Comment on attachment 31218 [details] [review]
fix

looks good to commit
Comment 6 Marco Pesenti Gritti 2004-09-04 17:17:14 UTC 
checked in
Comment 7 Christian Persch 2004-09-04 19:53:39 UTC 
Should we take this on gnome-2-8 too, after code freeze? IMHO yes.
Comment 8 Marco Pesenti Gritti 2004-09-05 04:37:19 UTC 
Yeah
Comment 9 Christian Persch 2004-09-13 10:38:25 UTC 
Fixed on gnome-2-8.