After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144669 - Register: Shortcut to filter accounts by account number
Register: Shortcut to filter accounts by account number
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: User Interface General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: David Hampton
Chris Shoemaker
: 162723 542768 (view as bug list)
Depends on:
Blocks: 473506 backport
 
 
Reported: 2004-06-19 19:10 UTC by Marc Bodmer
Modified: 2018-06-29 20:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow entering account codes in register (3.45 KB, patch)
2008-04-08 22:04 UTC, C.Ernst
committed Details | Review

Description Marc Bodmer 2004-06-19 19:10:38 UTC
Gnucash offers great support for keyboard shortcuts when selecting an account.
For example, to enter Assets:Checking, you might type A:C and let GnuCash fill
in the rest.

It would be very helpful though, if it would be possible to enter a number and
the displayed accounts are filtered by the account number.

If we take that example from the manual again:
We assume Assets:Checking has the account number 1234 assigned.

If the user types 12, every account starting with 12 will be displayed in the
list. If one matches exactly, when the user types 1234 it will be filled in by
gnucash.

For me this would be a very useful enhancement.
Comment 1 Chris Lyttle 2004-08-17 05:31:35 UTC
Hmm, I see what you mean here, you're talking about extending the Chart of
Accounts numbering to be able to use it as a sort by field. This is probably not
going to happen in the current version so I'm punting it to a future
possibility. Nice enhancement request, I agree it would be useful.
Comment 2 Christian Stimming 2005-01-25 09:19:15 UTC
*** Bug 162723 has been marked as a duplicate of this bug. ***
Comment 3 Christian Stimming 2005-01-25 09:22:23 UTC
Although the original enhancement request talks about "filtering" the accounts
by number, it would already be an enhancement if the accounts can be selected by
their exact number. Related to this is bug#129099 . 
Comment 4 C.Ernst 2008-04-08 22:04:28 UTC
Created attachment 108895 [details] [review]
Allow entering account codes in register

Lookup works like before, treating the user data as full name. If no account matches, the user data is used as input to look up the account by code.
Comment 5 Rolf Leggewie 2008-06-16 22:52:22 UTC
Christian, does attachment 108895 [details] [review] look sane to you?  I'd like to see it applied if indeed it does what it claims to be doing.

Thanks, Christoph, for the patch!  Greatly appreciated.
Comment 6 Rolf Leggewie 2008-06-16 23:23:32 UTC
running a build right now with the patch applied.  I hope I can test the binary tomorrow, but it might take another day or so before I can take a look at this.
Comment 7 Severin Heiniger 2008-06-17 09:46:37 UTC
Just gave gnucash a try with this patch applied and it worked like a charm. I'm sure the lack of this feature prevented quite a few people from using gnucash. Let this patch/feature be part of the next version's codebase, please!

Kuddos to Christoph for this great patch! Made my day.
Comment 8 Rolf Leggewie 2008-06-18 07:10:58 UTC
Working great.  Thanks for this awesome patch which brings us a great step closer to "gnucash for German business"
Comment 9 Rolf Leggewie 2008-06-18 10:04:42 UTC
just a question: can gnucash support type-ahead with relative ease here?  IOW, the user types 12 and gnucash will display accounts starting with 12.  Entering 121, then would further limit the list to those accounts starting with 121.
Comment 10 C.Ernst 2008-06-18 10:29:09 UTC
I doubt that auto completion makes much sense for numbers. Because you won't see what's behind 121. Also, I guess the number of keystroke you will save is much less than the number of keystrokes that is required to write that code :-)

Please have a look at bug#129099 which includes a patch to switch from account paths to simple names. If you consider using this patch e.g. with the german SKR03, which has the numbers included in the account names, you should get much better results than for auto completing numbers.
Comment 11 Andreas Köhler 2008-06-18 11:15:59 UTC
Derek, what is your opinion?
+1 from me, based on a quick glimpse.
Comment 12 Rolf Leggewie 2008-06-18 12:22:33 UTC
(In reply to comment #10)
> I doubt that auto completion makes much sense for numbers. Because you won't
> see what's behind 121. Also, I guess the number of keystroke you will save is
> much less than the number of keystrokes that is required to write that code :-)

I agree this is certainly not an absolute necessity.  Since the SKR accounts have a system it will often be possible to guess "the account I am looking for should be in the 4000 range" or something like that.  This is not about saving key strokes (you will often end up with more keystrokes) but about a lookup function integrated into the process of entering transactions.

> Please have a look at bug#129099 which includes a patch to switch from account
> paths to simple names. If you consider using this patch e.g. with the german
> SKR03

I use SKR04.  I am already following bug 129099 and will test out that patch shortly and propose it to be the next one included after that.
Comment 13 Derek Atkins 2008-06-18 16:40:33 UTC
Sure, the patch looks fine to me.  Keep in mind it wont change the way the QuickFill works.
Comment 14 Andreas Köhler 2008-06-18 17:36:37 UTC
Targetting for 2.2.6 then.
Comment 15 Rolf Leggewie 2008-07-03 08:45:45 UTC
Andi, what is holding you back from committing this to trunk?
Comment 16 Andreas Köhler 2008-07-03 10:29:03 UTC
Time.
Comment 17 Rolf Leggewie 2008-07-03 12:26:19 UTC
To save you on time, here are the copy&paste commands ;-)

cd $path2gnucashsource
wget http://bugzilla.gnome.org/attachment.cgi?id=108895&action=view
patch -p0 < "attachment.cgi?id=108895&action=view"
svn commit src/register/ledger-core/split-register.c src/engine/Account.c src/engine/Account.h

That shouldn't take more than a minute.  Thank you for your work in gnucash.
Comment 18 Andreas Köhler 2008-07-03 12:37:25 UTC
Please refrain from telling me how to use a computer :-)
BTW, did you consider that I might not have an svn checkout (ssh key) around?

The bug is targetted for 2.2.6, so what is the matter?
Comment 19 Rolf Leggewie 2008-07-03 13:13:07 UTC
well, first of all, you said it was lack of time, not lack of access to ssh key.  Furthermore, I find it hard to believe you being without access to that key for about two weeks.  And if that were the case, there should be somebody else to commit it.  That is sort of the issue, I have; to have a ready and tested patch for such an important enhancement linger around in the bug tracker for no particular reason.

BTW, the commit could have already been made in the time we have spent "arguing" here.

Maybe the easiest resolution is to increase my privileges so I can push this myself?
Comment 20 Andreas Köhler 2008-07-04 00:43:03 UTC
Applied to trunk as r17253.
Awaiting backport to branches/2.2.
Comment 21 Rolf Leggewie 2008-07-04 07:20:11 UTC
Great!

Many thanks.
Comment 22 Andreas Köhler 2008-07-08 19:19:56 UTC
Backported to branches/2.2 in r17277 by cstim for GnuCash 2.2.6.
Full stop
Comment 23 Allan Chandler 2008-07-15 05:19:21 UTC
*** Bug 542768 has been marked as a duplicate of this bug. ***
Comment 24 John Ralls 2018-06-29 20:44:20 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=144669. Please update any external references or bookmarks.