GNOME Bugzilla – Bug 144525
gtk dialog is not localized
Last modified: 2004-12-22 21:47:04 UTC
Description of Problem: gtkdialog is not localized. Steps to reproduce the problem: 1. Invoke gedit. 2. Choose [File] -> [Open] Actual Results: "Auto Detected", "Current locale" and "Add or Remove" are not localized. and also "Filesystem" in right pane in the dialog is not localized. Expected Results: All is correctly internationalized. How often does this happen? To open the dialog. Additional Information: I attached the patches.
Created attachment 28792 [details] [review] patch for gedit-2.5.92-orig/gedit/gedit-encodings-option-menu.c Added a patch
Created attachment 28793 [details] [review] patch for gtk+-2.4.1-orig/gtk/gtkfilechooserdefault.c Added another patch.
It seems that the 2nd patch is against gtk+: if so you should open a bug agaist gtk+ and attach the patch there... For what it worth, I may be wrong it doesn't look right to me: - afaik you can't mark with _() a string that is returned dinamically - if that was possible you are leaking the string
I submitted another bug 144529 about gtk. I cannot file any bugs via traditional interface because I get an error when submit bugs via Netscape 7.0 on Solaris.
Thanks for the bug report and the patches. The gtk+ patch is broken. You cannot apply _() to a non-constant string. The gedit patch is broken too, since you have to verify if HAVE_CONFIG_H is defined before including config.h You should add: #ifdef HAVE_CONFIG_H #include <config.h> #endif Please, fix the gedit patch as I suggested and commit in both the gnome-2-6 and HEAD branch (please, add an entry to gedit/ChangeLog).
Created attachment 28797 [details] [review] patch for gedit-2.5.92-orig/gedit/gedit-encodings-option-menu.c I revised the patch. I'll see the gtk patch.
Comment on attachment 28797 [details] [review] patch for gedit-2.5.92-orig/gedit/gedit-encodings-option-menu.c The new patch looks good. Please commit in both gnome-2-6 and HEAD branch (with a ChangeLog entry).
I don't have the account. Can I get it?
this was applied some time ago both on HEAD and on stable branch, but I forgot to close it. Thanks again for the patch Takao.