GNOME Bugzilla – Bug 144452
should show page title in window title
Last modified: 2005-09-26 21:08:22 UTC
Whenever one scrolls down from the top of the page, the current page isn't really indicated anywhere. It would be nice if the window title would include the page title always.
I like this feature too and also gtk+ documentation suggests to add document name to window title. "...A good title might include the application name and current document filename, for example..." <from gtk+2 docs>
Created attachment 46381 [details] [review] document name in window title This patch modify window title to include document name too ("%s - Devhelp", where %s is the opened document name).
Setting the PATCH keyword.
Could use some improvements, IMHO. Selecting links from Contents tab works quite nicely, however the rest not so well. Selecting functions from the Search tab gives you the clicked link as the window title (gtk_pattern_tag_new() - Devhelp) so as soon as you scroll the page a bit the title is no longer accurate. The title should be taken from the page title instead (which in this would've been GtkSourceTag) Furthermore clicking links in the content area is not updating the window title at all.
Created attachment 46447 [details] [review] use the HTML title as window title Different approach. Gecko signals when the page title changes, so use that to construct the window title. In this case it's important to signal every page change, not only when it's not empty, let the receiver decide how to handle NULL / empty title appropriately. I still kept the "%s - Devhelp" format even though including the application name in the window title is discouraged in the HIG.
Committed, thanks.