After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 144191 - Ctrl-L doesn't always open hidden toolbar
Ctrl-L doesn't always open hidden toolbar
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2004-06-11 23:04 UTC by Adam Hooper
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (1.54 KB, patch)
2004-06-11 23:49 UTC, Christian Persch 		none Details | Review

Description Adam Hooper 2004-06-11 23:04:52 UTC 
When View -> Toolbar is disabled, Ctrl-L doesn't always show the toolbar.

Expected behaviour: The toolbar should be shown and the focus should be on the
Location entry, until Enter/Escape is hit or the mouse is clicked, etc.

19:00 @chpe> works here
19:00 @chpe> (outside of fullscreen mode)
19:02 @chpe> hmmmm, it doesn't work the first time when toolbars were disabled
             at startup
19:02 @chpe> noda: -> bugzilla please :)
Comment 1 Christian Persch 2004-06-11 23:43:53 UTC 
This is a regression caused by the egg-editable-toolbar changes. The toolbar is
only constructed on realize. So when (on startup, or after a model change on
to/from fullscreen mode), the toolbar is invisible it isn't rebuilt; and
therefore the EphyLocationAction has no proxies it could activate.
Comment 2 Christian Persch 2004-06-11 23:49:57 UTC 
Created attachment 28615 [details] [review]
proposed fix

Realize the toolbar after creating it, and re-realize the toolbar after
changing the model.
Comment 3 Marco Pesenti Gritti 2004-06-12 07:48:46 UTC 
I think manually realizing is evil, this should really work trasparently :/
Comment 4 Christian Persch 2004-06-16 12:32:42 UTC 
Fixed in cvs.